[ENH] Add Feature load_model to Deep Regressor Ensembles#3130
[ENH] Add Feature load_model to Deep Regressor Ensembles#3130hadifawaz1999 merged 8 commits intoaeon-toolkit:mainfrom
Conversation
Thank you for contributing to
|
45d7989 to
dd34104
Compare
hadifawaz1999
left a comment
There was a problem hiding this comment.
Thanks for taking care of this
Just a few comments
889fa1b to
4a978a6
Compare
…eError in return type
…d LiteTimeRegressor (Closes aeon-toolkit#2770)
… all modified load_model docstrings.
81bc545 to
d0986b3
Compare
556a175 to
79b6719
Compare
1782d6e to
9187acb
Compare
Reference Issues/PRs
Fixes #2770
What does this implement/fix? Explain your changes.
This PR implements the missing load_model functionality for deep regressor ensembles and corrects a systemic documentation error found in the deep classifier ensembles.
Primary Feature (Feat):
Implements the
@classmethod load_modelforLITETimeRegressorandInceptionTimeRegressor.model_path: list[str]).test_lite_time.pyandtest_inception_time.pyto verify lossless save/load functionality usingregression_target=True.Systemic Fixes (Docs/Fix):
Based on mentor feedback, this PR includes essential fixes for code consistency and correctness:
BaseDeepClassifier,BaseDeepRegressor) and the deep classifier ensembles. Themodel_pathparameter is corrected to reflect that it is the path from which the model is loaded, not where it is "will be saved."NameErrorin theload_modelreturn type hint in theInceptionTimeClassifierandLITETimeClassifierby wrapping the class name in quotes (-> "InceptionTimeClassifier").Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
classesparameter in theload_modelsignature, as regressors do not deal with discrete labels.@classmethodsignature (selfinstead ofcls) to maintain consistency with the existing Aeon deep learning module structure.PR checklist
For all contributions
(Note: The suggested title starts with [FEAT] which is covered by the [ENH] (enhancement) tag often used in Aeon, or can be used on its own if the project allows it. We use the most relevant tags.)
For new estimators and functions
__maintainer__at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access