ETA-552: Consolidate testing — remove verification-loop skill#1166
Closed
ed-teal wants to merge 1 commit intoaffaan-m:mainfrom
Closed
ETA-552: Consolidate testing — remove verification-loop skill#1166ed-teal wants to merge 1 commit intoaffaan-m:mainfrom
ed-teal wants to merge 1 commit intoaffaan-m:mainfrom
Conversation
Merged verification-loop content into tdd-workflow and autonomous-loops. Removed verification-loop skill and all its mirrors (.agents/, .kiro/, docs/ja-JP, ko-KR, tr, zh-CN, zh-TW). Updated manifests, READMEs, and cross-references across 39 files.
Contributor
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe pull request consolidates verification functionality from a standalone Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Contributor
Greptile SummaryThis PR consolidates the Key changes:
Issues found:
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
VL["verification-loop skill\n(deleted)"]
VL -->|"6-phase verification gate\n(build, type-check, lint,\ntest, security, diff)"| TDD["tdd-workflow/SKILL.md\nPre-PR Verification Gate section"]
VL -->|"continuous validation\ncross-reference"| AL["autonomous-loops/SKILL.md\nReferences table updated"]
TDD -->|"replaces in"| CE["skills/configure-ecc/SKILL.md\n⚠️ duplicate tdd-workflow row"]
TDD -->|"replaces in"| AE[".kiro/skills/agentic-engineering/SKILL.md\n⚠️ duplicate bullet"]
TDD -->|"replaces in"| MODS["manifests/install-modules.json\n✅ path removed"]
TDD -->|"replaces in"| COMP["manifests/install-components.json\n✅ component removed"]
TDD -->|"replaces in"| CFG["agent.yaml / .opencode / .codex\n✅ references updated"]
CE --> ZNCN["docs/zh-CN/skills/configure-ecc\n⚠️ same duplicate"]
CE --> JAJP["docs/ja-JP/skills/configure-ecc\n⚠️ same duplicate"]
Reviews (1): Last reviewed commit: "ETA-552: Consolidate testing skills — re..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
148
to
+149
| | `tdd-workflow` | Enforces TDD with 80%+ coverage: unit, integration, E2E | | ||
| | `verification-loop` | Verification and quality loop patterns | | ||
| | `tdd-workflow` | TDD methodology with pre-PR verification gate | |
Contributor
There was a problem hiding this comment.
tdd-workflow entry in the Workflow & Quality table
The PR intended to replace the verification-loop row with a reference to tdd-workflow, but instead added a second tdd-workflow row. The table now lists the skill twice with inconsistent descriptions:
| `tdd-workflow` | Enforces TDD with 80%+ coverage: unit, integration, E2E |
| `tdd-workflow` | TDD methodology with pre-PR verification gate |
This will confuse anyone using the configure-ecc skill to choose which skills to install, since the same key appears twice. The fix is to remove one entry and merge the descriptions:
Suggested change
| | `tdd-workflow` | Enforces TDD with 80%+ coverage: unit, integration, E2E | | |
| | `verification-loop` | Verification and quality loop patterns | | |
| | `tdd-workflow` | TDD methodology with pre-PR verification gate | | |
| | `tdd-workflow` | Enforces TDD with 80%+ coverage (unit, integration, E2E) + pre-PR verification gate (build, type check, lint, security scan, diff review) | |
The same duplication occurs in the translated counterparts:
docs/zh-CN/skills/configure-ecc/SKILL.mdlines 152–153docs/ja-JP/skills/configure-ecc/SKILL.md(same pattern applied)
Comment on lines
131
to
+133
|
|
||
| - **tdd-workflow**: Combine with eval-first loop for test-driven development | ||
| - **verification-loop**: Use for continuous validation during implementation | ||
| - **tdd-workflow**: Also provides a pre-PR verification gate for continuous validation during implementation |
Contributor
There was a problem hiding this comment.
tdd-workflow bullet in Integration section
The replacement of the verification-loop bullet results in tdd-workflow being listed twice in the "Integration with Other Skills" section:
- **tdd-workflow**: Combine with eval-first loop for test-driven development
- **tdd-workflow**: Also provides a pre-PR verification gate for continuous validation during implementation
Both bullets should be merged into one to avoid redundancy:
Suggested change
| - **tdd-workflow**: Combine with eval-first loop for test-driven development | |
| - **verification-loop**: Use for continuous validation during implementation | |
| - **tdd-workflow**: Also provides a pre-PR verification gate for continuous validation during implementation | |
| - **tdd-workflow**: Combine with eval-first loop for test-driven development; also provides a pre-PR verification gate for continuous validation during implementation |
Contributor
Analysis CompleteGenerated ECC bundle from 500 commits | Confidence: 100% View Pull Request #1168Repository Profile
Detected Workflows (9)
Generated Instincts (38)
After merging, import with: Files
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
10 issues found across 39 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/ja-JP/skills/configure-ecc/SKILL.md">
<violation number="1" location="docs/ja-JP/skills/configure-ecc/SKILL.md:123">
P2: Workflow & Quality table now lists `tdd-workflow` twice (replacing `verification-loop`), leaving duplicate skill identifiers and incorrect guidance for selecting skills.</violation>
</file>
<file name="docs/zh-CN/README.md">
<violation number="1" location="docs/zh-CN/README.md:1051">
P3: The Codex skills table now lists `tdd-workflow` twice, which makes the skill inventory ambiguous and drops the distinct `verification-loop` entry.</violation>
</file>
<file name="docs/zh-CN/skills/configure-ecc/SKILL.md">
<violation number="1" location="docs/zh-CN/skills/configure-ecc/SKILL.md:153">
P2: The “工作流与质量（8 项技能）” list now contains a duplicate `tdd-workflow` entry, so the category claims 8 skills but only lists 7 unique ones after removing `verification-loop`. This misleads installers and should list a distinct replacement skill instead.</violation>
</file>
<file name=".kiro/skills/agentic-engineering/SKILL.md">
<violation number="1" location=".kiro/skills/agentic-engineering/SKILL.md:133">
P3: Integration list now contains two separate `tdd-workflow` bullets after removing `verification-loop`, which is likely an accidental duplication and reduces clarity of cross-skill references.</violation>
</file>
<file name="README.md">
<violation number="1" location="README.md:1066">
P2: Duplicate `tdd-workflow` entry in the Codex skills table—this replaces `verification-loop` but leaves the original `tdd-workflow` row, resulting in a duplicated skill name and an inaccurate inventory.</violation>
</file>
<file name="skills/tdd-workflow/SKILL.md">
<violation number="1" location="skills/tdd-workflow/SKILL.md:425">
P2: Piping build output to `tail` without pipefail masks the build’s exit status; the verification gate can falsely pass even when build/test fails.</violation>
<violation number="2" location="skills/tdd-workflow/SKILL.md:481">
P2: Diff review uses `git diff HEAD~1 --name-only`, which only lists files from the last commit. For multi-commit branches this omits earlier changes, undermining the full diff review step.</violation>
</file>
<file name=".codex/AGENTS.md">
<violation number="1" location=".codex/AGENTS.md:36">
P2: Duplicate `tdd-workflow` skill entry with conflicting descriptions in the skills inventory; this can confuse contributors or any tooling that expects unique skill names.</violation>
</file>
<file name=".kiro/docs/shortform-guide.md">
<violation number="1" location=".kiro/docs/shortform-guide.md:60">
P3: The quick reference now claims `tdd-workflow` includes a pre-PR verification gate, but the installed skill definition in `.kiro/skills/tdd-workflow/SKILL.md` doesn’t include any such gate. This makes the guide inaccurate for users relying on the `.kiro/skills` content.</violation>
</file>
<file name="skills/configure-ecc/SKILL.md">
<violation number="1" location="skills/configure-ecc/SKILL.md:149">
P2: Duplicate `tdd-workflow` entry in the Workflow & Quality table; the list should contain unique skills, but the new line repeats an existing skill instead of a unique one.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| | `strategic-compact` | 論理的な間隔で手動コンテキスト圧縮を提案 | | ||
| | `tdd-workflow` | 80%以上のカバレッジで TDD を強制: ユニット、統合、E2E | | ||
| | `verification-loop` | 検証と品質ループのパターン | | ||
| | `tdd-workflow` | TDD 方法論 + PR 前検証ゲート | |
Contributor
There was a problem hiding this comment.
P2: Workflow & Quality table now lists tdd-workflow twice (replacing verification-loop), leaving duplicate skill identifiers and incorrect guidance for selecting skills.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/ja-JP/skills/configure-ecc/SKILL.md, line 123:
<comment>Workflow & Quality table now lists `tdd-workflow` twice (replacing `verification-loop`), leaving duplicate skill identifiers and incorrect guidance for selecting skills.</comment>
<file context>
@@ -120,7 +120,7 @@ Options:
| `strategic-compact` | 論理的な間隔で手動コンテキスト圧縮を提案 |
| `tdd-workflow` | 80%以上のカバレッジで TDD を強制: ユニット、統合、E2E |
-| `verification-loop` | 検証と品質ループのパターン |
+| `tdd-workflow` | TDD 方法論 + PR 前検証ゲート |
**スタンドアロン**
</file context>
| | `strategic-compact` | 在逻辑间隔处建议手动上下文压缩 | | ||
| | `tdd-workflow` | 强制要求 TDD，覆盖率 80% 以上：单元测试、集成测试、端到端测试 | | ||
| | `verification-loop` | 验证和质量循环模式 | | ||
| | `tdd-workflow` | TDD 方法论 + PR 前验证门控 | |
Contributor
There was a problem hiding this comment.
P2: The “工作流与质量（8 项技能）” list now contains a duplicate tdd-workflow entry, so the category claims 8 skills but only lists 7 unique ones after removing verification-loop. This misleads installers and should list a distinct replacement skill instead.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/zh-CN/skills/configure-ecc/SKILL.md, line 153:
<comment>The “工作流与质量（8 项技能）” list now contains a duplicate `tdd-workflow` entry, so the category claims 8 skills but only lists 7 unique ones after removing `verification-loop`. This misleads installers and should list a distinct replacement skill instead.</comment>
<file context>
@@ -150,7 +150,7 @@ mkdir -p $TARGET/skills $TARGET/rules
| `strategic-compact` | 在逻辑间隔处建议手动上下文压缩 |
| `tdd-workflow` | 强制要求 TDD，覆盖率 80% 以上：单元测试、集成测试、端到端测试 |
-| `verification-loop` | 验证和质量循环模式 |
+| `tdd-workflow` | TDD 方法论 + PR 前验证门控 |
**类别：业务与内容（5 项技能）**
</file context>
| | strategic-compact | Context management | | ||
| | api-design | REST API design patterns | | ||
| | verification-loop | Build, test, lint, typecheck, security | | ||
| | tdd-workflow | TDD + build, test, lint, typecheck, security verification | |
Contributor
There was a problem hiding this comment.
P2: Duplicate tdd-workflow entry in the Codex skills table—this replaces verification-loop but leaves the original tdd-workflow row, resulting in a duplicated skill name and an inaccurate inventory.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At README.md, line 1066:
<comment>Duplicate `tdd-workflow` entry in the Codex skills table—this replaces `verification-loop` but leaves the original `tdd-workflow` row, resulting in a duplicated skill name and an inaccurate inventory.</comment>
<file context>
@@ -1064,7 +1063,7 @@ Skills at `.agents/skills/` are auto-loaded by Codex:
| strategic-compact | Context management |
| api-design | REST API design patterns |
-| verification-loop | Build, test, lint, typecheck, security |
+| tdd-workflow | TDD + build, test, lint, typecheck, security verification |
### Key Limitation
</file context>
| ```bash | ||
| # Show what changed | ||
| git diff --stat | ||
| git diff HEAD~1 --name-only |
Contributor
There was a problem hiding this comment.
P2: Diff review uses git diff HEAD~1 --name-only, which only lists files from the last commit. For multi-commit branches this omits earlier changes, undermining the full diff review step.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At skills/tdd-workflow/SKILL.md, line 481:
<comment>Diff review uses `git diff HEAD~1 --name-only`, which only lists files from the last commit. For multi-commit branches this omits earlier changes, undermining the full diff review step.</comment>
<file context>
@@ -458,6 +414,116 @@ npm test && npm run lint
+```bash
+# Show what changed
+git diff --stat
+git diff HEAD~1 --name-only
+```
+
</file context>
| ### Phase 1: Build Verification | ||
| ```bash | ||
| # Check if project builds | ||
| npm run build 2>&1 | tail -20 |
Contributor
There was a problem hiding this comment.
P2: Piping build output to tail without pipefail masks the build’s exit status; the verification gate can falsely pass even when build/test fails.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At skills/tdd-workflow/SKILL.md, line 425:
<comment>Piping build output to `tail` without pipefail masks the build’s exit status; the verification gate can falsely pass even when build/test fails.</comment>
<file context>
@@ -458,6 +414,116 @@ npm test && npm run lint
+### Phase 1: Build Verification
+```bash
+# Check if project builds
+npm run build 2>&1 | tail -20
+# OR
+pnpm build 2>&1 | tail -20
</file context>
| - strategic-compact — Context management | ||
| - api-design — REST API design patterns | ||
| - verification-loop — Build, test, lint, typecheck, security | ||
| - tdd-workflow — TDD + build, test, lint, typecheck, security verification |
Contributor
There was a problem hiding this comment.
P2: Duplicate tdd-workflow skill entry with conflicting descriptions in the skills inventory; this can confuse contributors or any tooling that expects unique skill names.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .codex/AGENTS.md, line 36:
<comment>Duplicate `tdd-workflow` skill entry with conflicting descriptions in the skills inventory; this can confuse contributors or any tooling that expects unique skill names.</comment>
<file context>
@@ -33,7 +33,7 @@ Available skills:
- strategic-compact — Context management
- api-design — REST API design patterns
-- verification-loop — Build, test, lint, typecheck, security
+- tdd-workflow — TDD + build, test, lint, typecheck, security verification
- deep-research — Multi-source research with firecrawl and exa MCPs
- exa-search — Neural search via Exa MCP for web, code, and companies
</file context>
| | `strategic-compact` | Suggests manual context compaction at logical intervals | | ||
| | `tdd-workflow` | Enforces TDD with 80%+ coverage: unit, integration, E2E | | ||
| | `verification-loop` | Verification and quality loop patterns | | ||
| | `tdd-workflow` | TDD methodology with pre-PR verification gate | |
Contributor
There was a problem hiding this comment.
P2: Duplicate tdd-workflow entry in the Workflow & Quality table; the list should contain unique skills, but the new line repeats an existing skill instead of a unique one.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At skills/configure-ecc/SKILL.md, line 149:
<comment>Duplicate `tdd-workflow` entry in the Workflow & Quality table; the list should contain unique skills, but the new line repeats an existing skill instead of a unique one.</comment>
<file context>
@@ -146,7 +146,7 @@ For each selected category, print the full list of skills below and ask the user
| `strategic-compact` | Suggests manual context compaction at logical intervals |
| `tdd-workflow` | Enforces TDD with 80%+ coverage: unit, integration, E2E |
-| `verification-loop` | Verification and quality loop patterns |
+| `tdd-workflow` | TDD methodology with pre-PR verification gate |
**Category: Business & Content (5 skills)**
</file context>
| | strategic-compact | 上下文管理 | | ||
| | api-design | REST API 设计模式 | | ||
| | verification-loop | 构建、测试、代码检查、类型检查、安全 | | ||
| | tdd-workflow | TDD + 构建、测试、代码检查、类型检查、安全验证 | |
Contributor
There was a problem hiding this comment.
P3: The Codex skills table now lists tdd-workflow twice, which makes the skill inventory ambiguous and drops the distinct verification-loop entry.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/zh-CN/README.md, line 1051:
<comment>The Codex skills table now lists `tdd-workflow` twice, which makes the skill inventory ambiguous and drops the distinct `verification-loop` entry.</comment>
<file context>
@@ -1049,7 +1048,7 @@ Codex macOS 应用：
| strategic-compact | 上下文管理 |
| api-design | REST API 设计模式 |
-| verification-loop | 构建、测试、代码检查、类型检查、安全 |
+| tdd-workflow | TDD + 构建、测试、代码检查、类型检查、安全验证 |
### 关键限制
</file context>
Suggested change
| | tdd-workflow | TDD + 构建、测试、代码检查、类型检查、安全验证 | | |
| | verification-loop | 构建、测试、代码检查、类型检查、安全 | |
|
|
||
| - **tdd-workflow**: Combine with eval-first loop for test-driven development | ||
| - **verification-loop**: Use for continuous validation during implementation | ||
| - **tdd-workflow**: Also provides a pre-PR verification gate for continuous validation during implementation |
Contributor
There was a problem hiding this comment.
P3: Integration list now contains two separate tdd-workflow bullets after removing verification-loop, which is likely an accidental duplication and reduces clarity of cross-skill references.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .kiro/skills/agentic-engineering/SKILL.md, line 133:
<comment>Integration list now contains two separate `tdd-workflow` bullets after removing `verification-loop`, which is likely an accidental duplication and reduces clarity of cross-skill references.</comment>
<file context>
@@ -130,6 +130,6 @@ Outcome: Success
- **tdd-workflow**: Combine with eval-first loop for test-driven development
-- **verification-loop**: Use for continuous validation during implementation
+- **tdd-workflow**: Also provides a pre-PR verification gate for continuous validation during implementation
- **search-first**: Apply before implementation to find existing solutions
- **coding-standards**: Reference during code review phase
</file context>
| | Skill | Use For | | ||
| |-------|---------| | ||
| | `tdd-workflow` | Red-green-refactor TDD cycle | | ||
| | `tdd-workflow` | Red-green-refactor TDD cycle + pre-PR verification gate | |
Contributor
There was a problem hiding this comment.
P3: The quick reference now claims tdd-workflow includes a pre-PR verification gate, but the installed skill definition in .kiro/skills/tdd-workflow/SKILL.md doesn’t include any such gate. This makes the guide inaccurate for users relying on the .kiro/skills content.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .kiro/docs/shortform-guide.md, line 60:
<comment>The quick reference now claims `tdd-workflow` includes a pre-PR verification gate, but the installed skill definition in `.kiro/skills/tdd-workflow/SKILL.md` doesn’t include any such gate. This makes the guide inaccurate for users relying on the `.kiro/skills` content.</comment>
<file context>
@@ -57,9 +57,8 @@ Type `/` in chat and select from the menu, or use:
| Skill | Use For |
|-------|---------|
-| `tdd-workflow` | Red-green-refactor TDD cycle |
+| `tdd-workflow` | Red-green-refactor TDD cycle + pre-PR verification gate |
| `security-review` | Comprehensive security audit |
-| `verification-loop` | Continuous validation and improvement |
</file context>
Suggested change
| | `tdd-workflow` | Red-green-refactor TDD cycle + pre-PR verification gate | | |
| | `tdd-workflow` | Red-green-refactor TDD cycle | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
verification-loop duplicated content already covered by tdd-workflow and autonomous-loops skills. Maintaining a separate skill for the same verification patterns added confusion without value.
What
How to Test
grep -r 'verification-loop' skills/ .agents/ .kiro/ docs/ manifests/should return nothingskills/tdd-workflow/SKILL.mdnow includes verification loop patternsAI Usage
Summary by cubic
Addresses ETA-552 by removing the
verification-loopskill and folding its verification gate intotdd-workflow(and references inautonomous-loops). Updates docs, manifests, and command maps so/verifyand/checkpointnow route throughtdd-workflow; total skills drop to 135.Refactors
skills/tdd-workflow/SKILL.mdand added a clear pre-PR verification gate; streamlined E2E guidance to referencee2e-testing.verification-loopacrossskills/,.agents/,.kiro/skills/, and all translated docs (ja-JP, ko-KR, tr, zh-CN, zh-TW).AGENTS.md, quick refs, and command maps to point/verifyand/checkpointtotdd-workflow; adjusted counts 136 → 135.agent.yaml,manifests/install-*, and.opencodeconfig.Migration
/verifyviatdd-workflowfor pre-PR checks.verification-loopreferences in project configs or docs.verification-loopreturns nothing; verification patterns now live inskills/tdd-workflow/SKILL.md.Written for commit 1efa71c. Summary will update on new commits.
Summary by CodeRabbit
verification-loopskill intotdd-workflow, which now includes a pre-PR verification gate covering build, type-check, lint, tests, security scans, and diff review./verifyand/checkpointcommands to execute via the enhancedtdd-workflowskill.