Skip to content

ETA-552: Consolidate testing — remove verification-loop skill #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ed-teal wants to merge 1 commit into from
Closed

ETA-552: Consolidate testing — remove verification-loop skill #1166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 0 additions & 126 deletions .agents/skills/verification-loop/SKILL.md
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions .agents/skills/verification-loop/agents/openai.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .codex/AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Available skills:
- eval-harness — Eval-driven development
- strategic-compact — Context management
- api-design — REST API design patterns
- verification-loop — Build, test, lint, typecheck, security
- tdd-workflow — TDD + build, test, lint, typecheck, security verification
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Apr 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Duplicate tdd-workflow skill entry with conflicting descriptions in the skills inventory; this can confuse contributors or any tooling that expects unique skill names.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .codex/AGENTS.md, line 36:

<comment>Duplicate `tdd-workflow` skill entry with conflicting descriptions in the skills inventory; this can confuse contributors or any tooling that expects unique skill names.</comment>

<file context>
@@ -33,7 +33,7 @@ Available skills:
 - strategic-compact — Context management
 - api-design — REST API design patterns
-- verification-loop — Build, test, lint, typecheck, security
+- tdd-workflow — TDD + build, test, lint, typecheck, security verification
 - deep-research — Multi-source research with firecrawl and exa MCPs
 - exa-search — Neural search via Exa MCP for web, code, and companies
</file context>
Fix with Cubic

- deep-research — Multi-source research with firecrawl and exa MCPs
- exa-search — Neural search via Exa MCP for web, code, and companies
- claude-api — Anthropic Claude API patterns and SDKs
Expand Down
17 changes: 7 additions & 10 deletions .kiro/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,9 @@ Skills are on-demand workflows invocable via the `/` menu in chat.

| Skill | Description |
|-------|-------------|
| `tdd-workflow` | Enforces test-driven development with 80%+ coverage including unit, integration, and E2E tests. Use when writing new features or fixing bugs. |
| `tdd-workflow` | Enforces TDD with 80%+ coverage (unit, integration, E2E) and includes a pre-PR verification gate (build, type check, lint, tests, security scan, diff review). Use when writing features, fixing bugs, or before creating PRs. |
| `coding-standards` | Universal coding standards and best practices for TypeScript, JavaScript, React, and Node.js. Use when starting projects, reviewing code, or refactoring. |
| `security-review` | Comprehensive security checklist and patterns. Use when adding authentication, handling user input, creating API endpoints, or working with secrets. |
| `verification-loop` | Comprehensive verification system that runs build, type check, lint, tests, security scan, and diff review. Use after completing features or before creating PRs. |
| `api-design` | RESTful API design patterns and best practices. Use when designing new APIs or refactoring existing endpoints. |
| `frontend-patterns` | React, Next.js, and frontend architecture patterns. Use when building UI components or optimizing frontend performance. |
| `backend-patterns` | Node.js, Express, and backend architecture patterns. Use when building APIs, services, or backend infrastructure. |
Expand Down Expand Up @@ -272,8 +271,6 @@ Shell scripts used by hooks to perform quality checks and formatting.
│ │ └── SKILL.md # Coding standards skill
│ ├── security-review/
│ │ └── SKILL.md # Security review skill
│ ├── verification-loop/
│ │ └── SKILL.md # Verification loop skill
│ ├── api-design/
│ │ └── SKILL.md # API design skill
│ ├── frontend-patterns/
Expand Down Expand Up @@ -361,7 +358,7 @@ All files are yours to modify after installation. The installer never overwrites
3. **Review your code**: Switch to `code-reviewer` agent after writing code
4. **Check security**: Use `security-reviewer` agent for auth, API endpoints, or sensitive data handling
5. **Run quality gate**: Trigger the `quality-gate` hook before committing
6. **Verify comprehensively**: Use the `verification-loop` skill before creating PRs
6. **Verify comprehensively**: Use the `tdd-workflow` skill's verification gate before creating PRs

The auto-loaded steering files (coding-style, security, testing) ensure consistent standards throughout your session.

Expand Down Expand Up @@ -404,10 +401,10 @@ kiro-cli --agent code-reviewer
# 2. Review specific files or directories
> "Review the changes in src/api/users.ts"

# 3. Use the verification-loop skill for comprehensive checks
> /verification-loop
# 3. Use the tdd-workflow verification gate for comprehensive checks
> /verify

# 4. The verification loop will:
# 4. The verification gate will:
# - Run build and type checks
# - Run linter
# - Run all tests
Expand Down Expand Up @@ -561,8 +558,8 @@ kiro-cli --agent refactor-cleaner
# - Suggest consolidation opportunities
# - Refactor safely without breaking changes

# 3. Use verification-loop after refactoring
> /verification-loop
# 3. Use verification gate after refactoring
> /verify
# Ensures all tests still pass after refactoring
```

Expand Down
2 changes: 1 addition & 1 deletion .kiro/docs/longform-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ Hooks create a safety net and capture knowledge automatically.
→ Agent identifies coupling, cohesion issues
→ Agent suggests refactoring strategy
2. Invoke refactor-cleaner agent with verification-loop skill
2. Invoke refactor-cleaner agent with tdd-workflow skill
→ Agent refactors incrementally
→ Agent runs tests after each change
→ Agent validates behavior preservation
Expand Down
2 changes: 1 addition & 1 deletion .kiro/docs/security-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ Plan a user authentication feature with these security requirements:
**Risk**: May accidentally remove security checks during refactoring.

**Mitigation**:
- Use verification-loop skill to validate behavior preservation
- Use tdd-workflow verification gate to validate behavior preservation
- Include security tests in test suite
- Review diffs carefully for removed security code
- Run security-reviewer after refactoring
Expand Down
5 changes: 2 additions & 3 deletions .kiro/docs/shortform-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,8 @@ Type `/` in chat and select from the menu, or use:

| Skill | Use For |
|-------|---------|
| `tdd-workflow` | Red-green-refactor TDD cycle |
| `tdd-workflow` | Red-green-refactor TDD cycle + pre-PR verification gate |
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Apr 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The quick reference now claims tdd-workflow includes a pre-PR verification gate, but the installed skill definition in .kiro/skills/tdd-workflow/SKILL.md doesn’t include any such gate. This makes the guide inaccurate for users relying on the .kiro/skills content.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .kiro/docs/shortform-guide.md, line 60:

<comment>The quick reference now claims `tdd-workflow` includes a pre-PR verification gate, but the installed skill definition in `.kiro/skills/tdd-workflow/SKILL.md` doesn’t include any such gate. This makes the guide inaccurate for users relying on the `.kiro/skills` content.</comment>

<file context>
@@ -57,9 +57,8 @@ Type `/` in chat and select from the menu, or use:
 | Skill | Use For |
 |-------|---------|
-| `tdd-workflow` | Red-green-refactor TDD cycle |
+| `tdd-workflow` | Red-green-refactor TDD cycle + pre-PR verification gate |
 | `security-review` | Comprehensive security audit |
-| `verification-loop` | Continuous validation and improvement |
</file context>
Suggested change
| `tdd-workflow` | Red-green-refactor TDD cycle + pre-PR verification gate |
| `tdd-workflow` | Red-green-refactor TDD cycle |
Fix with Cubic

| `security-review` | Comprehensive security audit |
| `verification-loop` | Continuous validation and improvement |
| `coding-standards` | Code style and standards enforcement |
| `api-design` | RESTful API design patterns |
| `frontend-patterns` | React/Vue/Angular best practices |
Expand Down Expand Up @@ -207,7 +206,7 @@ Toggle hooks in the Agent Hooks panel or edit `.kiro/hooks/*.kiro.hook` files.
"Analyze the user module architecture"

2. /agent swap refactor-cleaner
#verification-loop
#tdd-workflow
"Refactor based on the analysis"

3. /agent swap code-reviewer
Expand Down
2 changes: 1 addition & 1 deletion .kiro/skills/agentic-engineering/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,6 @@ Outcome: Success
## Integration with Other Skills

- **tdd-workflow**: Combine with eval-first loop for test-driven development
- **verification-loop**: Use for continuous validation during implementation
- **tdd-workflow**: Also provides a pre-PR verification gate for continuous validation during implementation
Comment on lines 131 to +133
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Duplicate tdd-workflow bullet in Integration section

The replacement of the verification-loop bullet results in tdd-workflow being listed twice in the "Integration with Other Skills" section:

- **tdd-workflow**: Combine with eval-first loop for test-driven development
- **tdd-workflow**: Also provides a pre-PR verification gate for continuous validation during implementation

Both bullets should be merged into one to avoid redundancy:

Suggested change
- **tdd-workflow**: Combine with eval-first loop for test-driven development
- **verification-loop**: Use for continuous validation during implementation
- **tdd-workflow**: Also provides a pre-PR verification gate for continuous validation during implementation
- **tdd-workflow**: Combine with eval-first loop for test-driven development; also provides a pre-PR verification gate for continuous validation during implementation

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Apr 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Integration list now contains two separate tdd-workflow bullets after removing verification-loop, which is likely an accidental duplication and reduces clarity of cross-skill references.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .kiro/skills/agentic-engineering/SKILL.md, line 133:

<comment>Integration list now contains two separate `tdd-workflow` bullets after removing `verification-loop`, which is likely an accidental duplication and reduces clarity of cross-skill references.</comment>

<file context>
@@ -130,6 +130,6 @@ Outcome: Success
 
 - **tdd-workflow**: Combine with eval-first loop for test-driven development
-- **verification-loop**: Use for continuous validation during implementation
+- **tdd-workflow**: Also provides a pre-PR verification gate for continuous validation during implementation
 - **search-first**: Apply before implementation to find existing solutions
 - **coding-standards**: Reference during code review phase
</file context>
Fix with Cubic

- **search-first**: Apply before implementation to find existing solutions
- **coding-standards**: Reference during code review phase
128 changes: 0 additions & 128 deletions .kiro/skills/verification-loop/SKILL.md
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .opencode/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ The default OpenCode config loads 11 curated ECC skills via the `instructions` a
- tdd-workflow
- strategic-compact
- eval-harness
- verification-loop
- api-design
- e2e-testing

Expand Down
1 change: 0 additions & 1 deletion .opencode/opencode.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"skills/frontend-slides/SKILL.md",
"skills/backend-patterns/SKILL.md",
"skills/e2e-testing/SKILL.md",
"skills/verification-loop/SKILL.md",
"skills/api-design/SKILL.md",
"skills/strategic-compact/SKILL.md",
"skills/eval-harness/SKILL.md"
Expand Down
Loading