Test against Py 3.11 + Break out non-DryRun-executing functions in blackbox.py into new script inspector.py#48
Merged
tzaffi merged 8 commits intoalgorand:mainfrom Jan 13, 2023
Conversation
tzaffi
changed the title
added 2 commits
January 12, 2023 16:56
tzaffi
changed the title
tzaffi
commented
Jan 12, 2023
| MAX_APP_ARG_LIMIT = atc.AtomicTransactionComposer.MAX_APP_ARG_LIMIT | ||
|
|
||
|
|
||
| class DryRunProperty(Enum): |
Contributor
Author
There was a problem hiding this comment.
This, and several other non-DryRun-execution related code has been broken out to inspector.py
tzaffi
commented
Jan 12, 2023
| @@ -0,0 +1,847 @@ | |||
| from base64 import b64decode | |||
Contributor
Author
There was a problem hiding this comment.
All this code came from blackbox.py. No changes other than the re-location.
tzaffi
changed the title
blackbox.py into new script inspector.py
tzaffi
pushed a commit
to tzaffi/graviton
that referenced
this pull request
Jan 13, 2023
tzaffi
commented
Jan 13, 2023
| inspector.max_stack_height() == 2 | ||
| inspector.status() == ("REJECT" if x == 0 else "PASS") | ||
| inspector.final_scratch() == ({} if x == 0 else {0: x}) | ||
| assert inspector.stack_top() == x**2 |
Contributor
Author
There was a problem hiding this comment.
for some reason, assertions were dropped. So I'm resuscitating these.
tzaffi
changed the title
blackbox.py into new script inspector.pyblackbox.py into new script inspector.py
added 2 commits
January 13, 2023 00:36
tzaffi
commented
Jan 13, 2023
| with: | ||
| config: ${{ env.SANDBOX_CONFIG }} | ||
| - name: Start algod | ||
| run: make algod-start |
| ) | ||
| from graviton.blackbox import ExecutionMode | ||
| from graviton.inspector import DryRunInspector, DryRunProperty, mode_has_property | ||
| from graviton.models import PyTypes |
|
i like it, good move forward |
Contributor
Author
Can i haz thummms up pleez |
ahangsu
approved these changes
Jan 13, 2023
Contributor
ahangsu
left a comment
ahangsu
left a comment
There was a problem hiding this comment.
generally lgtm, just moving classes from blackbox.py to inspector.py, and renamed BlackboxResults to DryRunResults. Together with a much simpler build.yml using Will's algod image.
bbroder-algo
approved these changes
Jan 13, 2023
This was referenced Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an attempt to make PR #45 easier to follow, I'm front running this one in first.
No new functionality is being introduced.
C.I. Improvements
Originally, graviton introduced an
algodfor the purposes of dry run testing. Later, PyTeal improved on it by bringingwwinder's nightly docker build. Now, the chickens have come home to roost and it's time to bring the PyTeal improved C.I. process back to graviton.Related issues - to be resolved: