feat(plugin): align plugin tool types with built-in tool capabilities#12050
feat(plugin): align plugin tool types with built-in tool capabilities#12050eXamadeus wants to merge 2 commits intoanomalyco:devfrom
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found potential related PRs: Potential Duplicates:
Recommendation: PR #9138 appears to be the most likely duplicate since it has the identical title. You should check if that PR is still open/active or if this PR (12050) supersedes it. PRs #6544 and #6042 appear to be related work on plugin tool capabilities but may already be merged. |
|
The bot is right, #9138 is the same PR and this one supersedes it. I changed base repos so I can maintain my fork easier. #6544 is the essentially same fix, but without the test addition. I'm happy to merge, close this out, or otherwise combine efforts. #6042 is unrelated. However, I think the changes #6042 proposes should probably be done through the SDK. The caveat is that #12042 needs to merge first. Then the |
60c9f24 to
d74b44a
Compare
a5812ca to
1253a51
Compare
e63f385 to
63101d8
Compare
63101d8 to
467d16e
Compare
What does this PR do?
Fixes: #8327
Related: #8269, #12042
This PR aligns plugin tool types with the capabilities tools already have. Specifically:
ToolContextfields to plugin tools:callID,extra,, andmetadata()to give plugins the correct context typesask()metadata()andask()were added in fix: add missing metadata() and ask() defintions to ToolContext type #8269ExecuteResulttype allowing plugin tools to return structured result objects withtitle,metadata,output, andattachmentsinstead of only plain stringsExecuteResultdirectly (assuming tools till truncate...we could add a check here?)This enables plugins to provide richer tool responses with proper metadata updates, closer matching the flexibility of built-in tools.
How did you verify your code works?
The types all align nicely in the registry