Merged
Conversation
jscheffl
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:dev-tools
area:UI
jscheffl
commented
May 21, 2025
bbovenzi
reviewed
May 21, 2025
Contributor
|
cc @TJaniF if you want to check any translations |
TJaniF
reviewed
May 22, 2025
TJaniF
reviewed
May 22, 2025
TJaniF
reviewed
May 22, 2025
TJaniF
reviewed
May 22, 2025
Contributor
Contributor
|
Let's rebase after the changes in #50930 |
jscheffl
force-pushed
the
feature/add-german-ui-translation
branch
from
af7217e to
9dd9b9f
Compare
TJaniF
approved these changes
May 23, 2025
Contributor
TJaniF
left a comment
TJaniF
left a comment
There was a problem hiding this comment.
Sehr cool! :)
Just a few small suggestions.
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
LGTM functionally, can't vouch for the translation accuracy unfortunately.
1 minor nit.
+1 for not translating core concepts and keeping their english version.
pierrejeambrun
approved these changes
May 23, 2025
jscheffl
force-pushed
the
feature/add-german-ui-translation
branch
from
9dd9b9f to
02db93c
Compare
Contributor
Author
Thanks @TJaniF for the review! Looking forward for the |
This was referenced May 23, 2025
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
* Add German UI translation * Add German UI translation, small nit * Review fedback * Rebase translation and some rework * Second review round
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Add German UI translation * Add German UI translation, small nit * Review fedback * Rebase translation and some rework * Second review round
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #50626 this adds German as language. Would also offer to take the CODEOWNER-ship to maintain German translation.
(Updated from commit 02db93c):
