Skip to content

Adjustment external views#51889

Merged
bbovenzi merged 6 commits intoapache:mainfrom
astronomer:51855-update-iframe-views
Jun 23, 2025
Merged

Adjustment external views#51889
bbovenzi merged 6 commits intoapache:mainfrom
astronomer:51855-update-iframe-views

Conversation

@pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Jun 18, 2025

Closes: #51855

@boring-cyborg boring-cyborg bot added area:airflow-ctl area:API Airflow's REST/HTTP API area:CLI area:plugins area:UI Related to UI/UX. For Frontend Developers. kind:documentation labels Jun 18, 2025
@pierrejeambrun pierrejeambrun added this to the Airflow 3.0.3 milestone Jun 18, 2025
@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Jun 18, 2025 •
edited
Loading

Second commit looks weird, (pre-commit hook formatting for generated files).

Fixed in: #51890

@pierrejeambrun pierrejeambrun force-pushed the 51855-update-iframe-views branch 2 times, most recently from 4c79e8e to 74dfc89 Compare June 18, 2025 15:33
bugraoz93
bugraoz93 approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks great! One test and UI Lint static check are falling in the CI. Might be great to get additional reviews for the UI side :)

bbovenzi
bbovenzi reviewed Jun 18, 2025
View reviewed changes
@pierrejeambrun pierrejeambrun force-pushed the 51855-update-iframe-views branch from 74dfc89 to 06d88e6 Compare June 19, 2025 07:53
@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Jun 19, 2025 •
edited
Loading

Still work needed to refine and handle the dark mode icon, icons for sub menus of app builder items, fix some styling, small refactoring and component extraction. (this wasn't introduced in this PR, I did my best to fix the smalls things that were straigh forward, but it needs more love, I will do that in a followup)

Single app builder menu item

Screenshot 2025-06-19 at 13 47 06

Multiple app builder menu items

Screenshot 2025-06-19 at 14 02 35

Single external_view

Screenshot 2025-06-19 at 14 07 03

Mixed

Screenshot 2025-06-19 at 14 09 00

jscheffl
jscheffl reviewed Jun 21, 2025
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some list of nit. Overall looking good.

Some formatting glitch also to be mentioned which should be fixed:

(1) Menu items have a different font pitch then category menues
(2) When I click on the menu on an iFrame link, the menu does not close

image

@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Jun 23, 2025

Thanks for the review Jens!

(1) Yes I also noticed that, I figured we will fix it in a followup PR because I don't have a straight forward for it and it was already existing prior to this PR.
(2) Nice, just fixed it.

@pierrejeambrun pierrejeambrun force-pushed the 51855-update-iframe-views branch from 6a5dec3 to a2bbc15 Compare June 23, 2025 16:57
@bbovenzi bbovenzi merged commit f22f756 into apache:main Jun 23, 2025
99 checks passed
@bbovenzi bbovenzi deleted the 51855-update-iframe-views branch June 23, 2025 20:10
@bbovenzi bbovenzi modified the milestones: Airflow 3.0.3, Airflow 3.1.0 Jun 23, 2025
@jscheffl
Copy link
Contributor

jscheffl commented Jun 23, 2025

Cool!

@pierrejeambrun pierrejeambrun mentioned this pull request Jun 24, 2025
Closed
@BBQing BBQing mentioned this pull request Jun 25, 2025
Closed
2 tasks
@pierrejeambrun pierrejeambrun mentioned this pull request Jun 26, 2025
Open
1 task
@tanujdargan tanujdargan mentioned this pull request Jun 28, 2025
Closed
@jscheffl jscheffl added the AIP-68 Extended Plugin Interface for React Views label Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jscheffl jscheffl jscheffl left review comments

@bbovenzi bbovenzi bbovenzi approved these changes

@bugraoz93 bugraoz93 bugraoz93 approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

@kaxil kaxil Awaiting requested review from kaxil

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner

@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

Assignees

No one assigned

Labels

AIP-68 Extended Plugin Interface for React Views area:airflow-ctl area:API Airflow's REST/HTTP API area:CLI area:plugins area:UI Related to UI/UX. For Frontend Developers. kind:documentation

Projects

None yet

Milestone

Airflow 3.1.0

Development

Successfully merging this pull request may close these issues.

AIP-68 | Merge iframe_views and appbuilder_menu_items

5 participants

@pierrejeambrun @jscheffl @bbovenzi @bugraoz93 @hussein-awala