Skip to content

GH-47105: [Statistics][C++] Implement Statistics specification attribute ARROW:row_count:approximate #48266

Merged
kou merged 1 commit intoapache:mainfrom
andishgar:row_count_approximate
Dec 3, 2025
Merged

GH-47105: [Statistics][C++] Implement Statistics specification attribute ARROW:row_count:approximate #48266
kou merged 1 commit intoapache:mainfrom
andishgar:row_count_approximate

Conversation

@andishgar
Copy link
Copy Markdown
Contributor

@andishgar andishgar commented Nov 26, 2025

Rationale for this change

Implement the statistics specification attribute ARROW:row_count:approximate.

What changes are included in this PR?

Implement the statistics specification attribute ARROW:row_count:approximate with relevant tests.

Are these changes tested?

Yes, I ran the related tests.

Are there any user-facing changes?

Yes, this adds the arrow::ArrayStatistics::row_count attribute.

@github-actions
Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@andishgar andishgar changed the title GH-#47105: [Statistics][C++] Implement Statistics specification attribute ARROW:row_count:approximate GH-47105: [Statistics][C++] Implement Statistics specification attribute ARROW:row_count:approximate Nov 26, 2025
@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #47105 has been automatically assigned in GitHub to PR creator.

@andishgar
Copy link
Copy Markdown
Contributor Author

Hi @kou, could you take a look at this?

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 322516f into apache:main Dec 3, 2025
43 of 46 checks passed
@kou kou removed the awaiting review Awaiting review label Dec 3, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Dec 3, 2025
@andishgar andishgar deleted the row_count_approximate branch December 3, 2025 01:14
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 322516f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants