Skip to content

GH-48404: [Python] Add tests to to_table(filter=...) to reject a boolean expr #48405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamreeve merged 1 commit into from
Dec 16, 2025
Merged

GH-48404: [Python] Add tests to to_table(filter=...) to reject a boolean expr #48405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion python/pyarrow/tests/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,14 @@ def test_dataset(dataset, dataset_reader):
assert isinstance(dataset, ds.Dataset)
assert isinstance(dataset.schema, pa.Schema)

# TODO(kszucs): test non-boolean Exprs for filter do raise
non_boolean_expr = ds.field('i64')
with pytest.raises(TypeError, match="must evaluate to bool"):
dataset.to_table(filter=non_boolean_expr)

non_boolean_expr2 = ds.field('i64') + 1
with pytest.raises(TypeError, match="must evaluate to bool"):
dataset.to_table(filter=non_boolean_expr2)

expected_i64 = pa.array([0, 1, 2, 3, 4], type=pa.int64())
expected_f64 = pa.array([0, 1, 2, 3, 4], type=pa.float64())

Expand Down
Loading