Skip to content

GH-48404: [Python] Add tests to to_table(filter=...) to reject a boolean expr#48405

Merged
adamreeve merged 1 commit intoapache:mainfrom
HyukjinKwon:GH-48404
Dec 16, 2025
Merged

GH-48404: [Python] Add tests to to_table(filter=...) to reject a boolean expr#48405
adamreeve merged 1 commit intoapache:mainfrom
HyukjinKwon:GH-48404

Conversation

@HyukjinKwon
Copy link
Copy Markdown
Member

@HyukjinKwon HyukjinKwon commented Dec 9, 2025

Rationale for this change

  • In order to remove the legacy TODO (from 9cb49f3)
  • To test non-boolean expressions to be rejected in the filter

What changes are included in this PR?

Added a couple of tests for non-boolean expressions at filter in to_table

Are these changes tested?

Yes, locally via pytest pyarrow/tests/test_dataset.py.

Are there any user-facing changes?

No, test-only.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2025

⚠️ GitHub issue #48404 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 10, 2025
@adamreeve adamreeve merged commit 16023ed into apache:main Dec 16, 2025
14 checks passed
@adamreeve adamreeve removed the awaiting committer review Awaiting committer review label Dec 16, 2025
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 16023ed.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants