Skip to content

GH-49632: [C++][R] Remove deprecated old MinGW CMake fixes for AWS#49633

Merged
kou merged 1 commit intoapache:mainfrom
raulcd:test-removing-old-mingw
Apr 2, 2026
Merged

GH-49632: [C++][R] Remove deprecated old MinGW CMake fixes for AWS#49633
kou merged 1 commit intoapache:mainfrom
raulcd:test-removing-old-mingw

Conversation

@raulcd
Copy link
Copy Markdown
Member

@raulcd raulcd commented Apr 1, 2026

Rationale for this change

We are using newer R version and MinGW CMAKE_CXX_COMPILER_VERSION is minimum 10.

What changes are included in this PR?

Remove unnecessary code paths for old MinGW on our CMake code.

Are these changes tested?

Yes via CI

Are there any user-facing changes?

No

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

⚠️ GitHub issue #49632 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Copy Markdown
Member Author

raulcd commented Apr 1, 2026

@github-actions crossbow submit -g r

@raulcd raulcd added the CI: Extra: R Run extra R CI label Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Revision: e8861d6

Submitted crossbow builds: ursacomputing/crossbow @ actions-c3a14a4ca5

Task Status
r-binary-packages GitHub Actions
r-recheck-most GitHub Actions
test-r-alpine-linux-cran GitHub Actions
test-r-arrow-backwards-compatibility GitHub Actions
test-r-depsource-system GitHub Actions
test-r-dev-duckdb GitHub Actions
test-r-devdocs GitHub Actions
test-r-extra-packages GitHub Actions
test-r-fedora-clang GitHub Actions
test-r-gcc-11 GitHub Actions
test-r-gcc-12 GitHub Actions
test-r-install-local GitHub Actions
test-r-install-local-minsizerel GitHub Actions
test-r-linux-as-cran GitHub Actions
test-r-linux-rchk GitHub Actions
test-r-linux-sanitizers GitHub Actions
test-r-linux-valgrind GitHub Actions
test-r-m1-san GitHub Actions
test-r-macos-as-cran GitHub Actions
test-r-offline-maximal GitHub Actions
test-r-ubuntu-22.04 GitHub Actions
test-r-versions GitHub Actions

@raulcd raulcd marked this pull request as ready for review April 1, 2026 08:58
@raulcd raulcd requested a review from kou April 1, 2026 09:53
Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Good catch!

@kou kou merged commit 976d547 into apache:main Apr 2, 2026
77 of 80 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Apr 2, 2026
@github-actions github-actions bot added the awaiting merge Awaiting merge label Apr 2, 2026
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 976d547.

There was 1 benchmark result with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 18 possible false positives for unstable benchmarks that are known to sometimes produce them.

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Apr 6, 2026
…AWS (apache#49633)

### Rationale for this change

We are using newer R version and MinGW CMAKE_CXX_COMPILER_VERSION is minimum 10.

### What changes are included in this PR?

Remove unnecessary code paths for old MinGW on our CMake code.

### Are these changes tested?

Yes via CI

### Are there any user-facing changes?
No

* GitHub Issue: apache#49632

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants