Migrate TableTestBase related classes to JUnit5 and delete TableTestBase#10063
Migrate TableTestBase related classes to JUnit5 and delete TableTestBase#10063nastra merged 2 commits intoapache:mainfrom
Conversation
tomtongue
changed the title
tomtongue
changed the title
tomtongue
force-pushed
the
mig-junit5-core-tabletestbase
branch
from
3a3470e to
e0ef61c
Compare
tomtongue
changed the title
|
@nastra Migrate all classes related to |
| import org.apache.iceberg.expressions.Expressions; | ||
| import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; | ||
| import org.apache.iceberg.util.StructLikeSet; | ||
| import org.junit.Assert; |
There was a problem hiding this comment.
still a JUnit4-Assert left here
There was a problem hiding this comment.
@nastra Thanks for the review. This time, I only migrate classes related to TableTestBase to delete the class, so I keep these classes JUnit4 because there should be a lot of changes if each class is updated to JUnit5. And, I'm thinking that after deleting TableTestBase, I'll migrate those classes to Junit 5. Should I update all classes in this PR to JUnit 5? or partially update?
There was a problem hiding this comment.
yeah indeed, that would lead to many changes. I'm ok doing the conversion from JUnit4 asserts to AssertJ on these files in a separate PR then
There was a problem hiding this comment.
Thank you. I'll create a PR to migrate them in a separate PR. At least, through this issue, we can delete the TableTestBase.
| @@ -35,33 +40,27 @@ | |||
| import org.apache.iceberg.util.StructLikeSet; | |||
| import org.assertj.core.api.Assertions; | |||
| import org.junit.Assert; | |||
There was a problem hiding this comment.
should be converted to AssertJ
| import org.apache.iceberg.deletes.PositionDelete; | ||
| import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; | ||
| import org.apache.iceberg.relocated.com.google.common.collect.Lists; | ||
| import org.junit.Assert; |
| @@ -65,31 +68,28 @@ | |||
| import org.apache.iceberg.util.StructLikeSet; | |||
| import org.assertj.core.api.Assertions; | |||
| import org.junit.Assert; | |||
| @@ -73,44 +77,39 @@ | |||
| import org.apache.iceberg.util.ThreadPools; | |||
| import org.junit.Assert; | |||
| import org.junit.Assume; | |||
2 participants
Migrate the following test classes to delete
TableTestBasefor #9085.Current Progress
WriterTestBaseTestFileWriterFactoryTestGenericFileWriterFactoryTestSparkFileWriterFactoryfor the versions: v3.3, v3.4, v3.5TestFlinkFileWriterFactoryfor the versions: v1.15, v1.16, v.1.17, v1.18TestPartitioningWritersTestSparkPartitioningWritersfor the versions: v3.3, v3.4, v3.5TestFlinkPartitioningWritersfor the versions: v1.15, v1.16, v.1.17, v1.18TestPositionDeltaWritersTestSparkPositionDeltaWritersfor the versions: v3.3, v3.4, v3.5TestFlinkPositionDeltaWritersfor the versions: v1.15, v1.16, v.1.17, v1.18TestRollingFileWritersTestSparkRollingFileWritersfor the versions: v3.3, v3.4, v3.5TestFlinkRollingFileWritersfor the versions: v1.15, v1.16, v.1.17, v1.18iceberg-flinkfor the versions: v1.15, v1.16, v.1.17, v1.18TestStreamingReaderOperatorTestStreamingMonitorFunctionTestIcebergFilesCommitterTestDeltaTaskWriter