Migrate TableTestBase related classes to JUnit5 #10080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Apr 3, 2024
| Assert.assertEquals(4, result.deleteFiles().size()); | ||
| Assert.assertEquals(0, result.referencedDataFiles().size()); | ||
| Assert.assertFalse(result.referencesDataFiles()); | ||
| assertThat(writer.result().deleteFiles()).hasSize(4); |
Contributor
There was a problem hiding this comment.
you may want to remove the result variable if you're using it directly here
Contributor
Author
There was a problem hiding this comment.
Oh sorry, I will update this part.
tomtongue
force-pushed
the
mig-junit5-tabletestbase-cls
branch
from
b22fb16 to
728caf8
Compare
nastra
approved these changes
Apr 3, 2024
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
the changes you have so far LGTM, is this PR still WIP or ready?
tomtongue
changed the title
Contributor
Author
Thanks for the review. This PR is ready, and all the classes are already migrated. Remove "WIP". |
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the following test classes to delete
TableTestBasefor #9085.This PR is for the migration of
TableTestBaserelated classes in #10063.Current Progress
Core:
(skipped)
TestContentFileParser(skipped)
TestFileScanTaskParserutil/TestTableScanUtilWriterTestBaseTestFileWriterFactoryTestGenericFileWriterFactoryTestSparkFileWriterFactoryfor the versions: v3.3, v3.4, v3.5TestFlinkFileWriterFactoryfor the versions: v1.16, v.1.17, v1.18TestPartitioningWritersTestSparkPartitioningWritersfor the versions: v3.3, v3.4, v3.5TestFlinkPartitioningWritersfor the versions: v1.16, v.1.17, v1.18TestPositionDeltaWritersTestSparkPositionDeltaWritersfor the versions: v3.3, v3.4, v3.5TestFlinkPositionDeltaWritersfor the versions: v1.16, v.1.17, v1.18TestRollingFileWritersTestSparkRollingFileWritersfor the versions: v3.3, v3.4, v3.5TestFlinkRollingFileWritersfor the versions: v1.16, v.1.17, v1.18iceberg-flinkfor the versions: v1.16, v.1.17, v1.18TestStreamingReaderOperatorTestStreamingMonitorFunctionTestIcebergFilesCommitterTestDeltaTaskWriter