fix(hydrator): use refresh paths from drySource when source hydration is enabled

[FourFifthsCode]

When using argocd.argoproj.io/manifest-generate-paths annotation with source hydrator enabled apps, make sure to base relative paths off of drySource path and not the sync source.

This fix allows hydration to properly trigger refreshes on paths specified by manifest-generate-paths annotation and wehbook handling.

Hydration with sourceHydrator:

• syncSource refresh without hydration
• drySource refresh with hydration

Standard apps without hydration refresh.

Partial fix for #25094

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Title of the PR
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[crenshaw-dev]

I'll override DCO if it becomes a huge pain to fix. :-)

[FourFifthsCode]

I'll override DCO if it becomes a huge pain to fix. :-)

I rebased on upstream and just cherry picked @pbhatnagar-oss's commits

[agaudreault]

I think after GetAppRefreshPaths is changed to receive the source in parameters, the implementation of the webhook handle event is much simpler.

if the app has an hydrator source configured, check the DrySource for change.
then, check the default source for change.

[codecov]

Codecov Report

❌ Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.65%. Comparing base (1dc85e5) to head (2038e9f).

Files with missing lines	Patch %	Lines
util/webhook/webhook.go	80.00%	2 Missing and 1 partial ⚠️
controller/state.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #25516      +/-   ##
==========================================
+ Coverage   62.61%   62.65%   +0.04%     
==========================================
  Files         353      353              
  Lines       50159    50181      +22     
==========================================
+ Hits        31405    31440      +35     
+ Misses      15737    15721      -16     
- Partials     3017     3020       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[agaudreault]

This should not be done. Should be empty if no annotation (same as normal source) since we cannot de assumptions on the users repository structure.

[FourFifthsCode]

ah, ok. I will update

[crenshaw-dev]

Suggested change

	// - if source hydrator configured AND source is drySource WITHOUT annotation: use dry source path
	// - if source hydrator configured AND source is drySource WITHOUT annotation: return empty slice (we can't make assumptions about the repo structure)

[crenshaw-dev]

Looking at the code, I don't think the corresponding change was pushed

[agaudreault]

LGTM!

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.1. Please check the workflow logs for details.

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.3. Please check the workflow logs for details.

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.2. Please check the workflow logs for details.

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.0. Please check the workflow logs for details.