Skip to content

fix(hydrator): empty links for failed operation (#25025)#26014

Merged
crenshaw-dev merged 1 commit intoargoproj:masterfrom
crenshaw-dev:fix-empty-links
Jan 15, 2026
Merged

fix(hydrator): empty links for failed operation (#25025)#26014
crenshaw-dev merged 1 commit intoargoproj:masterfrom
crenshaw-dev:fix-empty-links

Conversation

@crenshaw-dev
Copy link
Member

@crenshaw-dev crenshaw-dev commented Jan 15, 2026

Fixes #25025

Before (last two rows are problematic):

Screenshot 2026-01-15 at 4 05 54 PM

After (rows hidden):

Screenshot 2026-01-15 at 4 05 41 PM

Happy path still works w/ new code:

Screenshot 2026-01-15 at 4 06 29 PM

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@bunnyshell
Copy link

bunnyshell bot commented Jan 15, 2026

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@crenshaw-dev crenshaw-dev marked this pull request as ready for review January 15, 2026 21:11
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner January 15, 2026 21:11
@crenshaw-dev crenshaw-dev added cherry-pick/3.0 Candidate for cherry picking into the 3.0 release branch cherry-pick/3.1 Candidate for cherry picking into the 3.1 release branch cherry-pick/3.2 Candidate for cherry picking into the 3.2 release branch cherry-pick/3.3 Candidate for cherry picking into the 3.3 release component:hydrator Issue related to the Source Hydrator and commit server labels Jan 15, 2026
@crenshaw-dev crenshaw-dev merged commit ef40ba8 into argoproj:master Jan 15, 2026
42 of 44 checks passed
argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 15, 2026
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 15, 2026
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@argo-cd-cherry-pick-bot
Copy link

🍒 Cherry-pick PR created for 3.0: #26015

argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 15, 2026
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
argo-cd-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 15, 2026
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@argo-cd-cherry-pick-bot
Copy link

🍒 Cherry-pick PR created for 3.2: #26016

@argo-cd-cherry-pick-bot
Copy link

🍒 Cherry-pick PR created for 3.1: #26017

@argo-cd-cherry-pick-bot
Copy link

🍒 Cherry-pick PR created for 3.3: #26018

crenshaw-dev added a commit that referenced this pull request Jan 15, 2026
…26014 for 3.0) (#26015)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jan 15, 2026
…26014 for 3.1) (#26017)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jan 15, 2026
…26014 for 3.2) (#26016)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jan 15, 2026
…26014 for 3.3) (#26018)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
renovate bot added a commit to sdwilsh/ansible-playbooks that referenced this pull request Jan 31, 2026
##### [\`v3.2.6\`](https://github.com/argoproj/argo-cd/releases/tag/v3.2.6)

#### Quick Start

##### Non-HA:

```shell
kubectl create namespace argocd
kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v3.2.6/manifests/install.yaml
```

##### HA:

```shell
kubectl create namespace argocd
kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v3.2.6/manifests/ha/install.yaml
```

#### Release Signatures and Provenance

All Argo CD container images are signed by cosign.  A Provenance is generated for container images and CLI binaries which meet the SLSA Level 3 specifications. See the [documentation](https://argo-cd.readthedocs.io/en/stable/operator-manual/signed-release-assets) on how to verify.

#### Release Notes Blog Post

For a detailed breakdown of the key changes and improvements in this release, check out the [official blog post](https://blog.argoproj.io/argo-cd-v3-0-release-candidate-a0b933f4e58f)

#### Upgrading

If upgrading from a different minor version, be sure to read the [upgrading](https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/overview/) documentation.

#### Changelog

##### Bug fixes

- [`20866f4`](argoproj/argo-cd@20866f4): fix(hydrator): .gitattributes include deeply nested files ([#25870](argoproj/argo-cd#25870)) (cherry-pick [#26011](argoproj/argo-cd#26011) for 3.2) ([#26012](argoproj/argo-cd#26012)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot])
- [`508da9c`](argoproj/argo-cd@508da9c): fix(hydrator): empty links for failed operation ([#25025](argoproj/argo-cd#25025)) (cherry-pick [#26014](argoproj/argo-cd#26014) for 3.2) ([#26016](argoproj/argo-cd#26016)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot])
- [`2ff406a`](argoproj/argo-cd@2ff406a): fix: cherry pick [#25516](argoproj/argo-cd#25516) to release-3.2 ([#26115](argoproj/argo-cd#26115)) ([@FourFifthsCode](https://github.com/FourFifthsCode))
- [`e3b108b`](argoproj/argo-cd@e3b108b): fix: close response body on error paths to prevent connection leak (cherry-pick [#25824](argoproj/argo-cd#25824) for 3.2) ([#26006](argoproj/argo-cd#26006)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot])
- [`ad117b8`](argoproj/argo-cd@ad117b8): fix: invalid error message on health check failure ([#26040](argoproj/argo-cd#26040)) (cherry pick [#26039](argoproj/argo-cd#26039) for 3.2) ([#26070](argoproj/argo-cd#26070)) ([@dudinea](https://github.com/dudinea))

##### Dependency updates

- [`76fc92f`](argoproj/argo-cd@76fc92f): chore(deps): update notifications-engine to fix GitHub PR comments nil panic (cherry-pick [#26065](argoproj/argo-cd#26065) for 3.2) ([#26074](argoproj/argo-cd#26074)) ([@soutar](https://github.com/soutar))

**Full Changelog**: <argoproj/argo-cd@v3.2.5...v3.2.6>

<a href="https://argoproj.github.io/cd/"><img src="https://raw.githubusercontent.com/argoproj/argo-site/master/content/pages/cd/gitops-cd.png" width="25%" ></a>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/3.0 Candidate for cherry picking into the 3.0 release branch cherry-pick/3.1 Candidate for cherry picking into the 3.1 release branch cherry-pick/3.2 Candidate for cherry picking into the 3.2 release branch cherry-pick/3.3 Candidate for cherry picking into the 3.3 release component:hydrator Issue related to the Source Hydrator and commit server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Source Hydrator shows commit links even when there are no commits

2 participants

Comments