ci(deps): dedupe yarn.lock, add check for dupes#11637
ci(deps): dedupe yarn.lock, add check for dupes#11637terrytangyuan merged 2 commits intoargoproj:masterfrom
yarn.lock, add check for dupes#11637Conversation
|
Huh Prod UI build is failing on a That error suggests that one of the deps was relying on an outdated version of TS |
|
Ah yep, TS 4.6 was deduped and |
terrytangyuan
left a comment
There was a problem hiding this comment.
Can we combine this with other similar PRs?
|
One E2E test flake (I believe I've seen this one before too from a quick glance). |
- add a `deduplicate` script that uses `yarn-deduplicate` - run `deduplicate` during `make lint` and UI CI - run `deduplicate` once and commit the results - double-checked 50%+ of these automated changes and they all look good to me - similar to a commit I made in a library I maintained a few years ago: jaredpalmer/tsdx@22133ce Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
- due to a breaking change in TS 4.7 (TS does not follow SemVer), `ts-loader` needed an update: https://github.com/TypeStrong/ts-loader/blob/v9.4.4/CHANGELOG.md#v840 - `ts-loader` [v8](https://github.com/TypeStrong/ts-loader/blob/v9.4.4/CHANGELOG.md#v800)'s only breaking change was to no longer support TS <3.6 Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Head branch was pushed to by a user without write access
|
Geh, some other PR ended up merge conflicting as well 😭 Possibly #11678. Rebased on top |
Motivation
Use as few duplicates of dependencies as possible, reducing install size, memory usage, and bundle size
yarn.lockby condensing depsModifications
deduplicatescript that usesyarn-deduplicatededuplicateduringmake lintand UI CImake lintb/c that was honestly much more readable than trying to do multi-line shell conditionals inside of aMakefile(which require\and;as they get interpreted as a single line)deduplicateonce and commit the resultssimilar to a commit I made in a library I maintained a few years ago: jaredpalmer/tsdx@22133ce (part of jaredpalmer/tsdx#683)
Also, upgrade
ts-loaderto v8.4.0ts-loaderv8's only breaking change was to no longer support TS <3.6ts-loaderv9 requires Webpack v5, so cannot bump to that yet (see also build(ui): upgrade to Webpack v5 + upgrade loaders + plugins #11628)Verification
Ran the new
make lint: confirmed it worked and did not make an additional diff.Spot check on UI render was ok.
CI checks pass
Notes to Reviewers
This will likely merge conflict hard with a few my other open UI deps PRs, so it probably makes more sense to merge those first and then update this PR after those are all merged