Skip to content

Move search functions from LSDB -> HATS#1087

Merged
sedonaprice merged 3 commits intomainfrom
mv-search-funcs
Oct 16, 2025
Merged

Move search functions from LSDB -> HATS#1087
sedonaprice merged 3 commits intomainfrom
mv-search-funcs

Conversation

@sedonaprice
Copy link
Contributor

Moved lsdb.core.search submodule functions into a new hats.search submodule. The classes in the lsdb.core.search submodule remain in LSDB, as these are specifically implemented to work with LSDB catalogs.

Updated all relevant imports to import from hats.search and not lsdb.core.search.

This addresses part of #325, and helps to meet stcal usage needs (enabling only HATS as a dependency).

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.11%. Comparing base (ded5f0b) to head (36a0107).
⚠️ Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
- Coverage   97.15%   97.11%   -0.04%     
==========================================
  Files          46       46              
  Lines        2741     2704      -37     
==========================================
- Hits         2663     2626      -37     
  Misses         78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Oct 16, 2025

Before [ded5f0b] After [86f7c21] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_lazy_crossmatch_many_columns_all_suffixes
failed failed n/a benchmarks.time_lazy_crossmatch_many_columns_overlapping_suffixes
failed failed n/a benchmarks.time_open_many_columns_all
90.0±1ms 96.0±3ms 1.07 benchmarks.time_kdtree_crossmatch
25.8±0.2ms 27.1±0.9ms 1.05 benchmarks.time_box_filter_on_partition
5.67±0.01s 5.87±0.03s 1.04 benchmarks.time_create_large_catalog
856±4ms 872±3ms 1.02 benchmarks.time_create_midsize_catalog
1.65±0.01s 1.68±0.04s 1.01 benchmarks.time_open_many_columns_default
589±10ms 586±10ms 0.99 benchmarks.time_open_many_columns_list
43.9±2ms 43.3±2ms 0.99 benchmarks.time_polygon_search

Some benchmarks failed or their performance regressed significantly.

Copy link
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sedonaprice sedonaprice merged commit 7e9f77e into main Oct 16, 2025
13 checks passed
@sedonaprice sedonaprice deleted the mv-search-funcs branch October 16, 2025 19:48
@camposandro camposandro mentioned this pull request Nov 4, 2025
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants