Skip to content

Add Toggle Option for Facade Commit Messages#3353

Merged
MoralCode merged 1 commit intomainfrom
commit-message-toggle
Dec 16, 2025
Merged

Add Toggle Option for Facade Commit Messages#3353
MoralCode merged 1 commit intomainfrom
commit-message-toggle

Conversation

@IsaacMilarky
Copy link
Copy Markdown
Collaborator

Description

  • Add an option to be able to toggle collection for commit messages

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Copy link
Copy Markdown
Collaborator

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgoggins
Copy link
Copy Markdown
Collaborator

@IsaacMilarky : I think you said this was ready for review when we met the other day. Checking back because its still in "draft mode".

@MoralCode
Copy link
Copy Markdown
Collaborator

MoralCode commented Nov 1, 2025

My $0.02: could we make the new option more descriptive? Like "facade_process_commit_messages"?

Other users may not know what this is intuitively and the config is going to be most peoples main interaction with augur internals

@sgoggins
Copy link
Copy Markdown
Collaborator

sgoggins commented Nov 2, 2025

@IsaacMilarky : I think @MoralCode makes a good suggestion.

@sgoggins sgoggins added the config Items related to configuring augur settings/state to change how it behaves label Nov 2, 2025
@sgoggins sgoggins self-assigned this Nov 7, 2025
@sgoggins
Copy link
Copy Markdown
Collaborator

sgoggins commented Nov 7, 2025

@IsaacMilarky : Can you let us know if this is finished up?

@sgoggins sgoggins marked this pull request as ready for review November 13, 2025 18:21
@MoralCode MoralCode added this to the v0.92.0 Release milestone Nov 19, 2025
@MoralCode MoralCode merged commit abec3f1 into main Dec 16, 2025
15 checks passed
@MoralCode MoralCode deleted the commit-message-toggle branch December 16, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Items related to configuring augur settings/state to change how it behaves

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants