Skip to content

Add Toggle Option for Facade Commit Messages #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoralCode merged 1 commit into from
Dec 16, 2025
Merged

Add Toggle Option for Facade Commit Messages #3353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion augur/application/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ def get_development_flag():
"rebuild_caches": 1,
"run_analysis": 1,
"run_facade_contributors": 1,
"facade_contributor_full_recollect": 0
"facade_contributor_full_recollect": 0,
"commit_messages": 1,
},
"Server": {
"cache_expire": "3600",
Expand Down
5 changes: 3 additions & 2 deletions augur/tasks/git/facade_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@
facade_helper.log_activity('Debug',f"Commits missing from repo {repo_id}: {len(missing_commits)}")


if not len(missing_commits) or repo_id is None:

Check warning on line 258 in augur/tasks/git/facade_tasks.py

View workflow job for this annotation

GitHub Actions / runner / pylint 

[pylint] reported by reviewdog 🐶
C1802: Do not use `len(SEQUENCE)` without comparison to determine if a sequence is empty (use-implicit-booleaness-not-len)

Raw Output:
augur/tasks/git/facade_tasks.py:258:7: C1802: Do not use `len(SEQUENCE)` without comparison to determine if a sequence is empty (use-implicit-booleaness-not-len)
#session.log_activity('Info','Type of missing_commits: %s' % type(missing_commits))
return

Expand Down Expand Up @@ -315,7 +315,7 @@
facade_bulk_insert_commits(logger, pendingCommitRecordsToInsert)
pendingCommitRecordsToInsert = []

if commit_msg:
if commit_msg and facade_helper.commit_messages:
pendingCommitMessageRecordsToInsert.append(commit_msg)

if len(pendingCommitMessageRecordsToInsert) >= 1000:
Expand Down Expand Up @@ -446,7 +446,8 @@

analysis_sequence.append(trim_commits_post_analysis_facade_task.si(repo_git))

analysis_sequence.append(facade_fetch_missing_commit_messages.si(repo_git))
if facade_helper.commit_messages:
analysis_sequence.append(facade_fetch_missing_commit_messages.si(repo_git))

analysis_sequence.append(facade_analysis_end_facade_task.si())

Expand Down
1 change: 1 addition & 0 deletions augur/tasks/git/util/facade_worker/facade_worker/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ def __init__(self,logger: Logger):
self.multithreaded = worker_options["multithreaded"]
self.create_xlsx_summary_files = worker_options["create_xlsx_summary_files"]
self.facade_contributor_full_recollect = worker_options["facade_contributor_full_recollect"]
self.commit_messages = worker_options["commit_messages"]

self.tool_source = "Facade"
self.data_source = "Git Log"
Expand Down
Loading