Conversation
There was a problem hiding this comment.
Pull request overview
Updates centrally-managed Roslyn package versioning to address issue #335 about CS9057 warnings when consuming OllamaSharp with newer .NET SDKs.
Changes:
- Bumps
Microsoft.CodeAnalysis.Commonfrom4.14.0to5.0.0in central package versions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="5.0.0" /> | ||
| <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.0.0" /> |
There was a problem hiding this comment.
This version bump likely won’t address issue #335 (CS9057). The source generator project references Microsoft.CodeAnalysis.CSharp (and gets Microsoft.CodeAnalysis.Common transitively), so changing Microsoft.CodeAnalysis.Common here alone may have no effect on the analyzer assembly. Also, CS9057 is triggered when the analyzer references a newer compiler than the consuming SDK, so bumping the Roslyn dependency higher (e.g., from 4.14 to 5.0) would typically make the warning more likely for users on SDKs with an older compiler (like the reported 4.12). Consider pinning Microsoft.CodeAnalysis.CSharp/Common to the oldest compiler version you want to support (or multi-target/build the analyzer against that version) if the goal is to eliminate CS9057.
#335