Skip to content

Update Microsoft.CodeAnalysis.Common #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awaescher merged 2 commits into from
Mar 4, 2026
Merged

Update Microsoft.CodeAnalysis.Common #372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e30960
Update Microsoft.CodeAnalysis.Common
awaescher Mar 4, 2026
68df5c4
Merge branch 'main' into update-packages
awaescher Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ItemGroup>
<PackageVersion Include="coverlet.collector" Version="8.0.0" />
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="10.0.3" />
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.14.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="5.0.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.0.0" />
Comment on lines +8 to 9
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version bump likely won’t address issue #335 (CS9057). The source generator project references Microsoft.CodeAnalysis.CSharp (and gets Microsoft.CodeAnalysis.Common transitively), so changing Microsoft.CodeAnalysis.Common here alone may have no effect on the analyzer assembly. Also, CS9057 is triggered when the analyzer references a newer compiler than the consuming SDK, so bumping the Roslyn dependency higher (e.g., from 4.14 to 5.0) would typically make the warning more likely for users on SDKs with an older compiler (like the reported 4.12). Consider pinning Microsoft.CodeAnalysis.CSharp/Common to the oldest compiler version you want to support (or multi-target/build the analyzer against that version) if the goal is to eliminate CS9057.

Copilot uses AI. Check for mistakes.
<PackageVersion Include="Microsoft.Extensions.AI.Abstractions" Version="10.3.0" />
<PackageVersion Include="Microsoft.Extensions.AI" Version="10.3.0" />
Expand Down
Loading