feat(rtn-passkeys): scaffold native package - 1#14390
feat(rtn-passkeys): scaffold native package - 1#14390soberm merged 1 commit intofeat/rtn-passkeys/mainfrom
Conversation
jjarvisp
changed the title
jjarvisp
changed the title
jjarvisp
force-pushed
the
feat/rtn-passkeys/1-add-new-package
branch
from
c3efbfc to
773f40b
Compare
| implementation "androidx.credentials:credentials:1.5.0" | ||
| implementation "androidx.credentials:credentials-play-services-auth:1.5.0" | ||
|
|
||
| testImplementation "junit:junit:4.13.2" | ||
| testImplementation "org.robolectric:robolectric:4.14.1" | ||
| testImplementation "io.mockk:mockk:1.14.2" | ||
| testImplementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2" | ||
| testImplementation "org.jetbrains.kotlinx:kotlinx-coroutines-test:1.10.2" |
There was a problem hiding this comment.
These are manual changes required to support webauthn and enable unit testing.
| } | ||
|
|
||
| dependencies { | ||
| classpath "com.android.tools.build:gradle:8.7.3" |
There was a problem hiding this comment.
Maybe minor but the gradle version seems to be newer than other RTN packages in the repo, which is "8.0.2"
| AmplifyRtnPasskeys_kotlinVersion=2.1.20 | ||
| AmplifyRtnPasskeys_minSdkVersion=24 | ||
| AmplifyRtnPasskeys_targetSdkVersion=34 | ||
| AmplifyRtnPasskeys_compileSdkVersion=35 |
There was a problem hiding this comment.
Sanity check, it is OK a newer compile sdk version than other native packages right? Is PassKey feature only supported in 35?
There was a problem hiding this comment.
It's recommended to use the latest version of SDK when compiling and doesn't necessarily impact your minimum supported version unless you are using APIs that do not exist in previous versions.
Passkey is supported in sdk 28+ and there is validation to detect support in each platform implementation.
| "!ios/build", | ||
| "!android/build", | ||
| "!android/gradle", | ||
| "!android/gradlew", | ||
| "!android/gradlew.bat", | ||
| "!android/local.properties", | ||
| "!**/__tests__", | ||
| "!**/__fixtures__", | ||
| "!**/__mocks__", | ||
| "!**/.*" |
There was a problem hiding this comment.
Any concerns if we keep these files? I don't think we disabled these directories in other native packages.
There was a problem hiding this comment.
No concerns. I was just trying to minimize the footprint of the shipped artifact. The build directories are git ignored so they'd automatically be omitted; this just makes it explicit. The gradle files aren't necessary.
* feat(rtn-passkeys): scaffold native package - 1 (#14390) feat: add rtn-passkeys package * feat(rtn-passkeys): modify existing implementation - 2 (#14391) * feat: add rtn-passkeys package * feat: modify existing implementation * chore: refactor exports --------- Co-authored-by: Michael Sober <msober@amazon.com> * feat(rtn-passkeys): add ios support - 3a (#14392) * feat(rtn-passkeys): add android support - 3b (#14393) * feat(rtn-passkeys): add native unit tests in ci - 4 (#14399) * feat(rtn-passkeys): enable e2e - 5 (#14400) * chore: add missing license headers * chore: download iOS platform and create simulator --------- Co-authored-by: James Jarvis <jjarvisp@amazon.com>
3 participants
Description of changes
The purpose of this PR is to add new package to contain react native library addition and scaffold turbo module for passkey support.
create-react-native-libraryfor initial scaffold; removes or refactors extraneous generated files.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.