feat(rtn-passkeys): add ios support - 3a#14392
Merged
soberm merged 4 commits intofeat/rtn-passkeys/mainfrom Jul 30, 2025
Merged
feat(rtn-passkeys): add ios support - 3a#14392soberm merged 4 commits intofeat/rtn-passkeys/mainfrom
soberm merged 4 commits intofeat/rtn-passkeys/mainfrom
Conversation
jjarvisp
changed the title
jjarvisp
force-pushed
the
feat/rtn-passkeys/2-modify-existing-impl
branch
from
abd18da to
8065ea4
Compare
jjarvisp
force-pushed
the
feat/rtn-passkeys/3a-add-ios-support
branch
2 times, most recently
from
c993348 to
8669899
Compare
AllanZhengYP
approved these changes
May 21, 2025
Member
AllanZhengYP
left a comment
AllanZhengYP
left a comment
There was a problem hiding this comment.
The general flow looks good to me. I will defer the review for ObjC & Swift code details to other reviewers.
jjarvisp
force-pushed
the
feat/rtn-passkeys/3a-add-ios-support
branch
from
8669899 to
b55f3a1
Compare
Base automatically changed from
feat/rtn-passkeys/2-modify-existing-impl
to
feat/rtn-passkeys/main
July 30, 2025 11:51
soberm
requested review from
HuiSF,
ashika112,
calebpollman and
maxbeck-amzn
as code owners
soberm
approved these changes
Jul 30, 2025
soberm
added a commit
that referenced
this pull request
Sep 19, 2025
* feat(rtn-passkeys): scaffold native package - 1 (#14390) feat: add rtn-passkeys package * feat(rtn-passkeys): modify existing implementation - 2 (#14391) * feat: add rtn-passkeys package * feat: modify existing implementation * chore: refactor exports --------- Co-authored-by: Michael Sober <msober@amazon.com> * feat(rtn-passkeys): add ios support - 3a (#14392) * feat(rtn-passkeys): add android support - 3b (#14393) * feat(rtn-passkeys): add native unit tests in ci - 4 (#14399) * feat(rtn-passkeys): enable e2e - 5 (#14400) * chore: add missing license headers * chore: download iOS platform and create simulator --------- Co-authored-by: James Jarvis <jjarvisp@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The purpose of this PR is to add iOS support for the React Native implementation of webauthn.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.