(aws-ecs-patterns): Integration testing of aws-ecs-patterns contains an invalid integration test

[AnuragMohapatra]

Describe the bug

The integration testing of the aws-ecs-patterns has an invalid docker being used,

1. When executed the container state always fails with the following message -
   

2. Looking at the docker and python file it never creates a webserver so the test on this location(

   aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.queue-processing-fargate-service-public.ts

   Line 18 in 7c62d68

   command: ['CMD-SHELL', 'curl -f http://localhost/ || exit 1'],

   ) ideally should always fail as it asks the container to either respond with a localhost response which is not possible as there is no web server building in the docker image or give exit 1 which is exit with failure.

3. It is possible there are other issues with the integration testing but I have found these while working on the bug - aws-ecs-patterns (QueueProcessingFargateService): non-editable Scaling Policy causes race conditions & dropped tasks #20706

Expected Behavior

All integration tests should be perfectly aligned and work as expected.

Current Behavior

Integration tests go into infinite loop until cloud formation tasks fail.

Reproduction Steps

Create a new integration step using the QueueProcessingFargateService, using the same Docker and the index.py with no webserver and the docker should be using the CMD command.

Possible Solution

1. Separate Docker file for separate fargate integration tests.
2. Queue processing is different from application load balancer.

Additional Information/Context

No response

CDK CLI Version

NA

Framework Version

2.115

Node.js Version

NA

OS

NA

Language

TypeScript

Language Version

No response

Other information

No response

[pahud]

Yes I see your point.

aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.queue-processing-fargate-service-public.ts

Line 18 in 7c62d68

command: ['CMD-SHELL', 'curl -f http://localhost/ || exit 1'],

The sqs-reader is not actually listening on http port so the health check would always fail.

Are you interested to submit a PR for that?

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.