chore(ecs-patterns): fix the integration tests of queue processing fargate service#28463
Merged
mergify[bot] merged 10 commits intoaws:mainfrom Dec 23, 2023
AnuragMohapatra:fix-28383-fixintegrationtestingofqueueprocessingfargateservice
Merged
chore(ecs-patterns): fix the integration tests of queue processing fargate service#28463mergify[bot] merged 10 commits intoaws:mainfrom AnuragMohapatra:fix-28383-fixintegrationtestingofqueueprocessingfargateservice
mergify[bot] merged 10 commits intoaws:mainfrom
AnuragMohapatra:fix-28383-fixintegrationtestingofqueueprocessingfargateservice
Conversation
github-actions
bot
added
bug
github-actions
bot
added
the
beginning-contributor
…singfargateservice
aws-cdk-automation
added
the
pr/needs-community-review
lpizzinidev
suggested changes
Dec 22, 2023
Contributor
lpizzinidev
left a comment
lpizzinidev
left a comment
There was a problem hiding this comment.
Thanks 👍
A couple of nits.
...eg/test/aws-ecs-patterns/test/fargate/integ.queue-processing-fargate-service-health-check.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/sqs-reader/index.py
Outdated
Show resolved
Hide resolved
....js.snapshot/asset.d3bdcfdd660bfe705ef686f270e773fc19d7c57af72814ab86e6e1c9ac2f7535/index.py
Outdated
Show resolved
Hide resolved
aws-cdk-automation
removed
the
pr/needs-community-review
…service' of https://github.com/AnuragMohapatra/aws-cdk into fix-28383-fixintegrationtestingofqueueprocessingfargateservice
lpizzinidev
suggested changes
Dec 23, 2023
Contributor
lpizzinidev
left a comment
lpizzinidev
left a comment
There was a problem hiding this comment.
Thanks 👍
Just update the integration test snapshots and this will be good for me.
...g-fargate-service-health-check.js.snapshot/aws-ecs-patterns-queue-health-check.template.json
Outdated
Show resolved
Hide resolved
...terns/test/fargate/integ.queue-processing-fargate-service-health-check.js.snapshot/tree.json
Outdated
Show resolved
Hide resolved
kaizencc
changed the title
kaizencc
approved these changes
Dec 23, 2023
Contributor
kaizencc
left a comment
kaizencc
left a comment
There was a problem hiding this comment.
(updated to chore because although this does fix something, it doesn't fix the public api :))
Thanks @AnuragMohapatra for taking this on and @lpizzinidev for reviewing. It looks like the changes you're adding are all reasonable + helpful, so I'm inclined to trust you that this is working now, or at least not worse than before :). Appreciate you taking on this integ test fix!
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…singfargateservice
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
paulhcsun
pushed a commit
to paulhcsun/aws-cdk
that referenced
this pull request
Jan 5, 2024
…rgate service (aws#28463) 1. Fixed the docker image to use Python 3.11 to stop the python3.6 out of date warning/error 2. Fixed the lambda container's entry point handler, causing the integration tests to go into an infinite loop. 3. Fixed/changed the public integration test to a health check test as the queue processing fargate service doesn't have a public-facing feature. Closes aws#28383. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28383.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license