chore: remove sdk v2 handler and associated tests#29868
Closed
chore: remove sdk v2 handler and associated tests#29868
Conversation
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
colifran
force-pushed
the
colifran/remove-v2-handler
branch
from
f7181b7 to
4de2618
Compare
colifran
changed the title
aws-cdk-automation
added
the
pr/needs-maintainer-review
comcalvi
suggested changes
Apr 23, 2024
.../@aws-cdk/custom-resource-handlers/lib/custom-resources/aws-custom-resource-handler/index.ts
Show resolved
Hide resolved
.../@aws-cdk/custom-resource-handlers/lib/custom-resources/aws-custom-resource-handler/index.ts
Show resolved
Hide resolved
.../@aws-cdk/custom-resource-handlers/lib/custom-resources/aws-custom-resource-handler/index.ts
Outdated
Show resolved
Hide resolved
.../@aws-cdk/custom-resource-handlers/lib/custom-resources/aws-custom-resource-handler/index.ts
Outdated
Show resolved
Hide resolved
.../@aws-cdk/custom-resource-handlers/lib/custom-resources/aws-custom-resource-handler/index.ts
Outdated
Show resolved
Hide resolved
.../@aws-cdk/custom-resource-handlers/lib/custom-resources/aws-custom-resource-handler/index.ts
Outdated
Show resolved
Hide resolved
.../@aws-cdk/custom-resource-handlers/lib/custom-resources/aws-custom-resource-handler/index.ts
Outdated
Show resolved
Hide resolved
.../@aws-cdk/custom-resource-handlers/lib/custom-resources/aws-custom-resource-handler/index.ts
Outdated
Show resolved
Hide resolved
.../@aws-cdk/custom-resource-handlers/lib/custom-resources/aws-custom-resource-handler/index.ts
Show resolved
Hide resolved
.../@aws-cdk/custom-resource-handlers/lib/custom-resources/aws-custom-resource-handler/index.ts
Show resolved
Hide resolved
1 task
Signed-off-by: Francis <colifran@amazon.com>
aws-cdk-automation
removed
the
pr/needs-maintainer-review
mergify bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Closes #29937 ### Reason for this change Adding assertions for `AwsCustomResource` will improve our test coverage. ### Description of changes Added assertions for `AwsCustomResource` to integ tests that were impacted by this [PR](#29868). ### Description of how you validated changes Assertions were validated by running the integ tests and verifying that it succeeded. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
1 task
comcalvi
approved these changes
Apr 24, 2024
Contributor
comcalvi
left a comment
comcalvi
left a comment
There was a problem hiding this comment.
LGTM! Nice work refactoring this thorny code, I think it's in a much better state now.
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Closes #29937 ### Reason for this change Adding assertions for `AwsCustomResource` will improve our test coverage. ### Description of changes Added assertions for `AwsCustomResource` to integ tests that were impacted by this [PR](#29868). ### Description of how you validated changes Assertions were validated by running the integ tests and verifying that it succeeded. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
added 12 commits
April 25, 2024 18:30
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #29882
Reason for this change
The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK.
Description of changes
I removed the v2 handler file and all associated unit tests. Additionally, I refactored the v3 handler and renamed it to
index.ts. The refactor I did consolidated logic that was spread across multiple files to be shared between the v2 handler and the v3 handler. Utility related functions are now contained inutils.tsand logic related to loading the SDK package that will be used in making the specific API call is now contained inload-sdk.ts.Description of how you validated changes
As a result of the handler file name changing and the handler logic being refactored, the asset hash for the v3 handler changed. The asset hash change resulted in integ test failures. All impacted integ tests were updated and deployed with successful results.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license