chore(batch): init base EC2 class for ECS and EKS#35868
Open
phuhung273 wants to merge 2 commits intoaws:mainfrom
Open
chore(batch): init base EC2 class for ECS and EKS#35868phuhung273 wants to merge 2 commits intoaws:mainfrom
phuhung273 wants to merge 2 commits intoaws:mainfrom
Conversation
github-actions
bot
added
p2
distinguished-contributor
1 task
github-actions
bot
added
effort/medium
aws-cdk-automation
added
the
pr/needs-community-review
abidhasan-aws
previously requested changes
Apr 2, 2026
Contributor
abidhasan-aws
left a comment
abidhasan-aws
left a comment
There was a problem hiding this comment.
Hi @phuhung273 ,
Thanks for the contribution.
I just have a small nit comment.
| readonly instanceTypes: ec2.InstanceType[]; | ||
|
|
||
| /** | ||
| * The instance types that this Compute Environment can launch. |
Contributor
There was a problem hiding this comment.
I think the this should be instance classes instead of instance types
Contributor
Author
There was a problem hiding this comment.
Thanks for your review. I've corrected this comment
aws-cdk-automation
removed
the
pr/needs-community-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
Signed-off-by: phuhung273 <phuhung.tranpham@gmail.com>
Signed-off-by: phuhung273 <phuhung.tranpham@gmail.com>
mergify
bot
dismissed
abidhasan-aws’s stale review
Pull request has been modified.
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Close #35859
Reason for this change
defaultInstanceClasses, useOptimalInstanceClasses, allocationStrategy, spotBidPercentage, instanceRole, launchTemplate, minvCpus, placementGroupand their related functions. I don't want to submit a huge refactor PR directly.Description of changes
Init base EC2 class for ECS and EKS, start with only minimal things:
Description of how you validated changes
Unit + Integ
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license