Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

Changed API for remote services#29

Merged
ChristianKuehnel merged 13 commits intomasterfrom
remote_services_2
Feb 24, 2018
Merged

Changed API for remote services#29
ChristianKuehnel merged 13 commits intomasterfrom
remote_services_2

Conversation

@ChristianKuehnel
Copy link
Copy Markdown

@ChristianKuehnel ChristianKuehnel commented Feb 23, 2018

After the comments on the PR in Home Assistant (home-assistant/core#12591), here's a proposal to a new API for the remote services:

  • The call to e.g. trigger_remote_door_lock now blocks until we get a final answer from the server. Note: this might take some time.
  • If the vehicle state is expected to change after the call: an update of the vehicle state is triggered after a call to the remote services.
  • The account now offers a listener to subscribe to vehicle state changes. This is necessary so that we can notify all listeners after an updated is triggered by a call to a remote service
  • I incremented the version number, as this is a breaking API change.
  • Added horn and climate control as remote services. ⚠️ I could not yet test these on a live vehicle. It's just implemented after the other examples...
  • Update to unit tests to cover the changed code.

@ChristianKuehnel ChristianKuehnel added the library 🗃️ Related to this library label Feb 23, 2018
This was referenced Feb 23, 2018
@ChristianKuehnel
Copy link
Copy Markdown
Author

@gerard33 please have a look at the changed API. It that what you and Martin discussed?

Right now I only implemented the synchronous case. I'm not sure if we want to add async as well...

@ChristianKuehnel ChristianKuehnel merged commit d63ba80 into master Feb 24, 2018
@ChristianKuehnel ChristianKuehnel deleted the remote_services_2 branch February 24, 2018 11:15
@lock
Copy link
Copy Markdown

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

library 🗃️ Related to this library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant