This repository was archived by the owner on Mar 9, 2026. It is now read-only.
Changed API for remote services#29
Merged
ChristianKuehnel merged 13 commits intomasterfrom Feb 24, 2018
Merged
Conversation
* updated test suite accordingly
This was referenced Feb 23, 2018
Closed
Author
|
@gerard33 please have a look at the changed API. It that what you and Martin discussed? Right now I only implemented the synchronous case. I'm not sure if we want to add async as well... |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the comments on the PR in Home Assistant (home-assistant/core#12591), here's a proposal to a new API for the remote services: