Merged
Conversation
Emoji char codes are bigger than String.fromCharCode() supports. String.fromCodePoint() has a larger range. Fixes TryGhost/Ghost#11541.
Member
|
Thank you. Updated the title as they work correctly on desktop. Tests are passing. The failure is due to account secrets not working in forks that we need to figure out. |
daniellockyer
pushed a commit
to TryGhost/mobiledoc-kit
that referenced
this pull request
Aug 16, 2022
* Fix emoji inputs. Emoji char codes are bigger than String.fromCharCode() supports. String.fromCodePoint() has a larger range. Fixes TryGhost/Ghost#11541. * Add a unit test. Co-authored-by: Garth Poitras <411908+gpoitch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many emoji char codes are bigger than String.fromCharCode() supports. String.fromCodePoint() has a larger range that allows emojis.
Fixes TryGhost/Ghost#11541.