Skip to content

Fix emoji input on iOS #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpoitch merged 3 commits into from
Aug 11, 2022
Merged

Fix emoji input on iOS #764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d306ce0
Fix emoji inputs.
JBYoshi Aug 11, 2022
81a2d91
Add a unit test.
JBYoshi Aug 11, 2022
3948cf0
Merge branch 'master' into emojis
gpoitch Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/utils/key.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export default class Key {
if (this.isTab()) {
return TAB
}
return String.fromCharCode(this.charCode)
return String.fromCodePoint(this.charCode)
}

// See https://caniuse.com/#feat=keyboardevent-key for browser support.
Expand Down
12 changes: 12 additions & 0 deletions tests/unit/utils/key-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,15 @@ test('uses keyCode as a fallback if key is not supported', assert => {
keyInstance = Key.fromEvent(event)
assert.ok(keyInstance.isSpace(), 'keyCode is used if key is not supported')
})

test('properly handles UTF-16 characters', assert => {
let element = $('#qunit-fixture')[0]

let event = Helpers.dom.createMockEvent('keypress', element, {
key: '😀',
keyCode: 128512,
charCode: 128512,
})
let keyInstance = Key.fromEvent(event)
assert.equal('😀', keyInstance.toString(), 'emoji was not properly decoded')
})