feat(breakpoints): add watchpoint input to breakpoint panel#167
Open
alikhere wants to merge 1 commit intoc2siorg:mainfrom
Open
feat(breakpoints): add watchpoint input to breakpoint panel#167alikhere wants to merge 1 commit intoc2siorg:mainfrom
alikhere wants to merge 1 commit intoc2siorg:mainfrom
Conversation
alikhere
force-pushed
the
feat/gdbui-watchpoint-ui
branch
from
57faeb1 to
6a04a95
Compare
Author
|
Hi @Shubh942 Could you please review the PR whenever you get time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The
/add_watchpointendpoint existed on the backend but had no UI.I added a watch expression input alongside the existing breakpoint form so you can finally set watchpoints from the browser. It sends the expression to the backend and shows a toast on success or validation failure.
How to test
Open the app, go to the Break Points panel, type a variable name into the watch input and hit add. Confirm the request hits
/add_watchpointand a toast appears. Try submitting empty to confirm the validationmessage shows.Related Issue
Fixes #166
Notes
npm run lintstill reports the same pre-existing ESLint errors asbefore — nothing new introduced by this change.