Skip to content

New design#252

Merged
lorenzo merged 8 commits into
cakephp:3.1from
midorikocak:new-design
Jun 10, 2015
Merged

New design#252
lorenzo merged 8 commits into
cakephp:3.1from
midorikocak:new-design

Conversation

@midorikocak
Copy link
Copy Markdown
Contributor

To correct branch.

@midorikocak
Copy link
Copy Markdown
Contributor Author

these two should happen together

#252
cakephp/bake#104

@markstory markstory added this to the 3.1.0 milestone May 30, 2015
Comment thread webroot/css/cake.css Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the other selectors are one per line.

@midorikocak
Copy link
Copy Markdown
Contributor Author

whoa. holy eyeglasses. I am going to fix it now.

Comment thread src/Template/Layout/default.ctp Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

@midorikocak
Copy link
Copy Markdown
Contributor Author

Midori means green japanese :) check my website: http://www.mtkocak.com

I did not touch the old css and I added new features after line 385, maybe some Css optimization for unneeded parts?
Comment thread src/Template/Layout/default.ctp Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

lorenzo added a commit that referenced this pull request Jun 10, 2015
@lorenzo lorenzo merged commit 657cf0a into cakephp:3.1 Jun 10, 2015
@midorikocak
Copy link
Copy Markdown
Contributor Author

Proud of it :)

@jadb
Copy link
Copy Markdown
Contributor

jadb commented Jun 10, 2015

nice job! 👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there ways to do away with the inline classes? (also see below)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants