New design generators

[midorikocak]

I think I have to update tests too...

[markstory]

Looks like the tests do need to be updated. I would wait until the feedback rounds are done before updating the test to save some work.

[AD7six]

You can auto-update the test expectations by temporarily modifying the string compare trait like so:

    public function assertSameAsFile($path, $result)
    {
        $path = $this->_compareBasePath . $path;
        file_put_contents($path, $result); // <-
        $expected = file_get_contents($path);
        $this->assertTextEquals($expected, $result);
    }

Then running the affected/failing tests, committing and pushing the changes to the tests folder.

[markstory]

Indentation seems off.

[midorikocak]

is there any cakephp 3 bundle for textmate?

[markstory]

@mtkocak I'm not sure, I've not used textmate in years. However, you may be able to find a generic PHP bundle that supports PSR-2 formatting.

[midorikocak]

I think I did it. I updated all tests manually and tested using phpunit. by the way @markstory what ide do you use?

[midorikocak]

coverage/coveralls ? @AD7six

[AD7six]

Coverage decreased (-0.2%)

You can ignore that @mtkocak - all the test files are missing a newline at the end of the file. Apart from that 👍 great work =).

[midorikocak]

oh I see. I got coverage problem because I did not fetch 1.1 :P I am going to add new lines too

[markstory]

@mtkocak Just vim with some config/plugins.

[midorikocak]

@markstory thanks for the advice, I will try that.

[lorenzo]

Great job @mtkocak 👏

[ADmad]

I see that class templateTaskComments was already used earlier but it should be switched to dashed version for consistency.

[jadb]

👍

[ionas]

Are there ways to do away with the inline classes?

[ADmad]

I don't see how you can do away with classes for column widths.

[htstudios]

By using css (or sass or scss or less).

[ADmad]

@jhli What's wrong with existing css classes used?

[htstudios]

Not depending on whatever-framework-was used style.
being able to replace the presentation.
http://alistapart.com/article/separationdilemma
http://alistapart.com/column/no-good-can-come-of-bad-code

In this case the way without a preprocessor would be to copy the class attribute to css as a comment also refering to the franework utilized AND below create the very few selectors and include their properties.

I am very happy with the inprovement though as now it looks good!

[midorikocak]

I am totally lost.

[ionas]

Don't worry. It got merged, it is tons better now. Thank you 👍 for making me love cake bake output visually again! :)