Add missing parent call for Table::initialize().#124
Conversation
|
Is there a way to remove that whitespace noise in the bake templates when generating? |
|
It fails because bakes output contains extra whitespace - the correct fix is to fix the output, looks to me like this is responsible: There shouldn't be any "echo whitespace" logic in these templates, only echo statements at the right indentation level. |
|
Or running a trim right on the generated code on a per row level. |
I don't want that kind of logic - the template is right, or it's not. not mostly-right with magic applied. There'll be cases where you want/expect trailing whitespace and that'd prevent it. |
|
Seems fine one the tests pass. |
|
Feel free to fix the unrelated whitespace issue either as commits on top or separate PR. |
|
@dereuromark it's changes in this pr that cause the test fails (it previously matched output, unrelated changes to the test file in this PR make it fail). As I've mentioned before its easy to get the test output to match expectations - I can fix the now-apparent bad template later/tomorrow. |
This shouldn't be in any templates
Whitespace should never be output by php code. Also, implode shouldn't be abused to construct code like that either
Add missing parent call for Table::initialize().
Closes #120