Only set primary key fields as non-accessible.

[ADmad]

This change avoids having to update the accessible list when new fields are added to table.

This avoids some hair pulling for new users who don't realize the entity also needs to be updated if they change table fields. I have seen newbies often struggle to figure out why their new fields are not getting saved. e.g. http://stackoverflow.com/questions/31385268/cakephp-3-new-fields-wont-save-correctly

[lorenzo]

Make me sad making the security feature less obvious

[ADmad]

@lorenzo Life is full of compromises 😄

[markstory]

😢 At least people who need more secure apps have better tools at their disposal.

[GuidoHendriks]

👎 I'd rather have security by default than ease of use for "newbies".

[Spriz]

+1 to @GuidoHendriks 😄

[ADmad]

@GuidoHendriks @Spriz I am not particularly thrilled by this change either but keeping things simpler for newbies is also important as initial impressions matter.

You can use custom bake template to get earlier behavior.

[bcrowe]

Maybe we should add a note to the docblock?

[ADmad]

@bcrowe Sounds good, can you please make a PR with appropriate text?

[ndm2]

The fields and no-fields options are now kinda superflous as they are not being used anymore. I'm wondering whether they should be removed, or maybe incorporated again, so that they override the default behavior in case they are being used? ie, if no-fields is used, don't created $_accessible, if fieldsis used, fill $_accessible with only those fields specified.

[markstory]

I would expect fields would result in specific fields being added into the accessible list.

[ndm2]

@markstory You mean added to what is currently being generated (the * and the primary key fields)?

[markstory]

Well if there is an explicit lust of fields from the user only those fields should be marked accessible.

[ndm2]

OK, that's what I was suggesting too, I misunderstood you then. I'll try to implement this before I continue with the entity property hints.

[htstudios]

Maybe instead mass assigning to a field that is not accessible could throw a warning on debug true?