Skip to content

fix detect Controller name#361

Merged
markstory merged 1 commit into
cakephp:masterfrom
saeideng:test_controller
Sep 15, 2017
Merged

fix detect Controller name#361
markstory merged 1 commit into
cakephp:masterfrom
saeideng:test_controller

Conversation

@saeideng
Copy link
Copy Markdown
Member

@saeideng saeideng commented Sep 15, 2017

invalid result when using
bin/cake bake test Controller Users --prefix=Admin
but when using controller instead of Controller
returned true result

@markstory markstory merged commit f5e93a4 into cakephp:master Sep 15, 2017
@markstory
Copy link
Copy Markdown
Member

markstory commented Sep 15, 2017

Thanks!

@markstory markstory added this to the 1.3.x milestone Sep 15, 2017
markstory added a commit that referenced this pull request Nov 22, 2017
@markstory
Remove duplicate prefix name being applied.
79bf6b9 
In #361 the type check was fixed which resulted in prefixed controllers
having their prefixes doubled when tests were generated. By removing the
code in ControllerTask tests generate correctly again.

Refs #377
@markstory markstory mentioned this pull request Nov 22, 2017
Merged
@saeideng saeideng deleted the test_controller branch February 3, 2018 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3.x

Development

Successfully merging this pull request may close these issues.

2 participants

@saeideng @markstory