Skip to content

Remove duplicate prefix name being applied.#379

Merged
markstory merged 1 commit intomasterfrom
prefix-controller-test
Nov 23, 2017
Merged

Remove duplicate prefix name being applied.#379
markstory merged 1 commit intomasterfrom
prefix-controller-test

Conversation

@markstory
Copy link
Copy Markdown
Member

In #361 the type check was fixed which resulted in prefixed controllers having their prefixes doubled when tests were generated. By removing the code in ControllerTask tests generate correctly again.

Refs #377

In #361 the type check was fixed which resulted in prefixed controllers
having their prefixes doubled when tests were generated. By removing the
code in ControllerTask tests generate correctly again.

Refs #377
@markstory markstory added this to the 1.5.x milestone Nov 22, 2017
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 22, 2017

Codecov Report

Merging #379 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #379      +/-   ##
============================================
- Coverage     92.12%   92.11%   -0.02%     
+ Complexity      665      664       -1     
============================================
  Files            25       25              
  Lines          2184     2181       -3     
============================================
- Hits           2012     2009       -3     
  Misses          172      172
Impacted Files Coverage Δ Complexity Δ
src/Shell/Task/ControllerTask.php 100% <ø> (ø) 23 <0> (-1) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fcd0f3...79bf6b9. Read the comment docs.

@dereuromark
Copy link
Copy Markdown
Member

Looks good.

@markstory markstory merged commit 0ba0910 into master Nov 23, 2017
@markstory markstory deleted the prefix-controller-test branch November 23, 2017 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants