Support both networkd and NetworkManger in netplan (New)#1301
Merged
fernando79513 merged 18 commits intomainfrom Sep 12, 2024
Merged
Support both networkd and NetworkManger in netplan (New)#1301fernando79513 merged 18 commits intomainfrom
fernando79513 merged 18 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 45.72% 46.30% +0.58%
==========================================
Files 367 367
Lines 39134 39224 +90
Branches 6618 6636 +18
==========================================
+ Hits 17894 18164 +270
+ Misses 20565 20374 -191
- Partials 675 686 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5933112 to
14accb6
Compare
14accb6 to
ac16772
Compare
p-gentili
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Port bugfix from #1301 * Update tests
ac16772 to
6b39662
Compare
Contributor
Author
|
Rebase |
Collaborator
fernando79513
left a comment
There was a problem hiding this comment.
Good job here! A bunch of minor comments and suggestions but nothing big.
I think at least one of the tests is wrong (test_main_success). Please check that the test is testing the expected behavior.
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
23f6967 to
ff34f12
Compare
Contributor
Author
|
@fernando79513 please review these changes~~ |
fernando79513
previously approved these changes
Sep 12, 2024
Hook25
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Netplan serves as a network configuration abstraction renderer and was officially released in the 24.04 LTS version.
Netplan functions as a configuration tool for back-end daemons managing network interfaces, such as NetworkManager or systemd-networkd.
In essence, Netplan acts as a configuration tool for back-end daemons managing network interfaces, independent of specific technologies.
In this PR, modify the
wifi_client_test_netplan.pyscript to make it support both networkd and NetworkManger.generate_test_configto create the configuration with the specified renderer.wait_for_routableto support both networkd and NetworkManager._get_nmcli_stateto retrieve the connection state for NetworkManager.check_routable_stateto determine the appropriate_get_{nmcli | networkctl}_statebased on the renderer parameter.perform_ping_testto accommodate both networkd and NetworkManager. (Obtain the Gateway method)get_gateway, which will select the appropriate_get_{networkctl | nmcli}_gatewaybased on the renderer parameter._get_networkctl_gatewayextracted from the func: perform_ping_test to support this functionality._get_nmcli_gatewayto obtain the gateway IP address from NetworkManager.print_journal_entriesto cater to both network and NetworkManager scenarios.According to the above issue, it need to add the following action:
Resolved issues
#1303 (Netplan missing the key-management: psk when wpa/wpa2)
Documentation
Tests
Run cmd on systemd-networkd machine 202405-34023
Run checkbox wireless test category on machine 202405-34023