netplan bugfix declare auth for non wpa3 (bugfix)#1306
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
=======================================
Coverage 44.17% 44.18%
=======================================
Files 359 359
Lines 38812 38813 +1
Branches 6581 6581
=======================================
+ Hits 17147 17148 +1
Misses 21003 21003
Partials 662 662
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hook25
changed the title
p-gentili
approved these changes
Jun 21, 2024
Collaborator
p-gentili
left a comment
p-gentili
left a comment
There was a problem hiding this comment.
Tested on https://certification.canonical.com/hardware/201805-26252, works fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a bugfix ported from #1301
The issue is that by not declaring the auth kind, the netbplan is not correctly parsed.
Resolved issues
Fixes: CHECKBOX-1471
Documentation
N/A
Tests
@p-gentili is testing this to see if it works in production, unit tests were updated