Replace check_dss.sh with an appropriate Python script (New)#1726
Closed
Replace check_dss.sh with an appropriate Python script (New)#1726
check_dss.sh with an appropriate Python script (New)#1726Conversation
This will replace check_dss.sh in the near future.
We no longer need microk8s, but instead use the kubeconfig from well known default directory. It also prepares us to have this run on a K8s different than microk8s
DSS may choose to use a namespace with any name in the future.
replacing the old check_dss.sh calls; now with also custom, explicit, and potentially larger timeouts for creating some notebooks.
replacing check_dss.sh calls, which were also giving the false impression that the notebooks were removed immediately. DSS's documentation only promises to start removing the notebook, and returns almost immediately.
Contributor
Author
|
Waiting on #1725 to be merged so that we have the required |
This was referenced Feb 14, 2025
Contributor
Author
|
Closing in lieu of a better solution in #1743. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the next piece of the original PR #1724 that requires PR #1725.
The main changes in this PR include replacing the existing
check_dss.shand its usages with the more or less the same functionality implemented as a Python script.1 test has been removed since it relied on the name of the DSS namespace being something specific.
1 test has been added that tests DSS's public API for
dss purge.Resolved issues
Documentation
No changes to the Checkbox documentation.
Tests
#1725 needs to be merged before this PR to enable running the tests in the CI.