Replaced DSS shell scripts with Python and added running DSS integration tests (New)#1724
Closed
Replaced DSS shell scripts with Python and added running DSS integration tests (New)#1724
Conversation
remove a test case of verifying dss namespace is deployed. that will be done using kubectl. it is covered by the upcoming integration tests from dss as well.
renamed some notebooks to be explicitly checkbox related
now we rely on kubectl so that canonical-k8s can be tested in the future
used ce-oem provider's relevant code as inspiration.
helps run in parallel, and potentially avoid getting the same flaky machine every time
to better reflect which channels are currently available
the raised exception was not including these
motjuste
changed the title
Collaborator
|
Please, Abdullah, try to split this PR into smaller ones. Since you have basically have 5 new main scripts, try to have a PR for each one of them, and maybe another one for creating the new workflow. |
fernando79513
added
the
waiting-for-changes
Contributor
Author
|
I understand your complaint, and would like to apologise. I have created a new PR #1725 with the first important pieces. Please have a look. More PRs will follow after that one is merged. Closing this for the moment then. |
This was referenced Feb 14, 2025
This was referenced Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tox.ini. The tests can also be run locally following recommendations added to the README.Resolved issues
Documentation
No changes to Checkbox documentation.
Tests
The testing GH workflow has been added in this PR. These were run using Testflinger, with the coverage report available at the bottom of the full report here.
A run of the GH workflow to test DSS with this provider was started here. Unfortunately, this workflow is not reliable to always succeed, failing during provisioning from Testflinger, failing due to bugs in DSS, etc.
A manual run was submitted to Testflinger testing DSS 1/stable (which has the latest changes) against microk8s 1.28/stable, and its report can be found here.