Replace check_cuda.sh with simple in-line commands (New)#1750
Merged
fernando79513 merged 3 commits intomainfrom Mar 10, 2025
Merged
Replace check_cuda.sh with simple in-line commands (New)#1750fernando79513 merged 3 commits intomainfrom
check_cuda.sh with simple in-line commands (New)#1750fernando79513 merged 3 commits intomainfrom
Conversation
We also rename this unit to include the work microk8s in anticipation of a future request to enable the addon in a different k8s environment
The now obsolete check_cuda.sh can now also be removed
This will be re-usable when enabling NVIDIA GPU in other K8s
fernando79513
approved these changes
Mar 7, 2025
Collaborator
fernando79513
left a comment
fernando79513
left a comment
There was a problem hiding this comment.
Good job here, LGTM!
We can merge this as soon as the check_dss PR is merged
stanley31huang
pushed a commit
that referenced
this pull request
Mar 28, 2025
* Inline script to enable gpu addon in microk8s We also rename this unit to include the work microk8s in anticipation of a future request to enable the addon in a different k8s environment * Inline verifying nvidia gpu validations The now obsolete check_cuda.sh can now also be removed * Factor out checking NVIDIA GPU rollout This will be re-usable when enabling NVIDIA GPU in other K8s
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Inline script to enable gpu addon in microk8s We also rename this unit to include the work microk8s in anticipation of a future request to enable the addon in a different k8s environment * Inline verifying nvidia gpu validations The now obsolete check_cuda.sh can now also be removed * Factor out checking NVIDIA GPU rollout This will be re-usable when enabling NVIDIA GPU in other K8s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the next piece of the original PR #1724. I was drafting #1727 but then got the idea for a much simpler solution, partly also from the review of #1725. While not strictly required, it is best to merge this after #1743.
The main changes in this PR include:
nvidia_gpu_addon/enabletomicrok8s_nvidia_gpu_addon/enableto reflect that this unit will attempt enabling the GPU addon in microk8s. We expect to add a different unit for enabling the GPU addon in other K8s soon.check_nvidia_gpu_rollout.shin anticipation that it will be useful in other K8s soon.check_cuda.shcheck_cuda.sh.Resolved issues
Documentation
No changes to the Checkbox documentation.
Tests
No new tests were added. I have tested this branch in a machine from Testflinger manually. I need the changes to the
job-def.yamlfrom #1743 to have a fully automated Testflinger job result.