Conversation
Minor: reword text and actually upload
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1937 +/- ##
==========================================
+ Coverage 50.39% 50.54% +0.15%
==========================================
Files 384 384
Lines 41095 41112 +17
Branches 6753 7629 +876
==========================================
+ Hits 20709 20782 +73
+ Misses 19644 19586 -58
- Partials 742 744 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
fernando79513
left a comment
fernando79513
left a comment
There was a problem hiding this comment.
Nice clean-up!!
You have already proven that the functionality is there with the pipelines, so I've only added some minor changes for clarity.
Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
mreed8855
pushed a commit
that referenced
this pull request
Jul 30, 2025
* Unify tox for all core components * Fix workflow syntax * Fix libsvm version * Remove pkg-resources from all tests in checkbox_support * Remove non-codecov tox * Format github output to make it parsable * Try to add output and re-format back wrong syntax * Make output a list of dicts Minor: reword text and actually upload * Remove all outdated (duplicated) workflows * Add comment documentation Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * Add a name metadata to step --------- Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
mreed8855
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Unify tox for all core components * Fix workflow syntax * Fix libsvm version * Remove pkg-resources from all tests in checkbox_support * Remove non-codecov tox * Format github output to make it parsable * Try to add output and re-format back wrong syntax * Make output a list of dicts Minor: reword text and actually upload * Remove all outdated (duplicated) workflows * Add comment documentation Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com> * Add a name metadata to step --------- Co-authored-by: Fernando Bravo <39527354+fernando79513@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our tox workflows are mostly the same for core components, but duplicated (for the most part) because triggering on path changes in a smart-ish way is a bit bothersome. This tries to unify them, triggering only those that change if any did, and all if the workflow changes. This has the advantage of "centralizing" all of these workflows in one place but also simplifies reviewing the dependabot prs because the trigger on workflow changes was missing on some of the tox workflows (sigh). Another thing that was missing was the 3.12 toxing, with whom I discovered some tests still using pkg_resources I fixed in this PR.
Resolved issues
Partially fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1915 (stepping stone)
Documentation
N/A
Tests
N/A (a run will trigger on this PR)