Update the Virtualization Test to Wait Before Checking the Virtual Machine

[mreed8855]

Update the Virtualization Test to Wait Before Checking the Virtual Machine (Bugfix)

This fixes this issue
#695

Jira Card
https://warthogs.atlassian.net/browse/SERVCERT-1259

Description

The test works fine, but is a bit quick to start trying to ssh into the VM, causing several retries. This makes the log noisy.

Update the virtualization test to wait 2 minutes before checking if the virtual machine
has booted. This will clean up the logs and reduce the amount of possible failed attempts in the logs.

Resolved issues

#695

Documentation

Tests

Run checkbox and run the virtualization/verify_lxd_vm job

[codecov]

Codecov Report

Merging #720 (018572e) into main (fa62fd0) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   32.97%   32.97%   -0.01%     
==========================================
  Files         302      302              
  Lines       35170    35172       +2     
  Branches     6144     6144              
==========================================
  Hits        11598    11598              
- Misses      23020    23022       +2     
  Partials      552      552              

Flag	Coverage Δ
provider-base	1.93% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
providers/base/bin/virtualization.py	0.00% <0.00%> (ø)

[bladernr]

LGTM, thanks!

[kissiel]

The constant 2min is a solid delay that's being introduced. I strongly recommend doing a busy loop for the same amount of time. For instance checking every 5s whether it booted, and doing the rest of the actions after the timeout rings.

The codecov is unhappy about the shrinking coverage. Also in the PR template there should have been an info about the suffix that helps us generate the changelog automatically (in this case (BugFix)).

I will be happy to assist you if you need more hands on those issues.

[mreed8855]

The constant 2min is a solid delay that's being introduced. I strongly recommend doing a busy loop for the same amount of time. For instance checking every 5s whether it booted, and doing the rest of the actions after the timeout rings.
On line 885 there is already the busy loop that you just described that checks the vm every 5 seconds for 5 minutes. The purpose of the 2 minute delay is to reduce the amount of checks in the log. I am open to suggestions. I could increase the wait time in the loop?

The codecov is unhappy about the shrinking coverage. Also in the PR template there should have been an info about the suffix that helps us generate the changelog automatically (in this case (BugFix)).
I added (BugFix) in the Description is that correct?

I will be happy to assist you if you need more hands on those issues.
Any assistance is appreciated

[bladernr]

On Thu, Sep 14, 2023 at 4:32 PM mreed8855 ***@***.***> wrote: The constant 2min is a solid delay that's being introduced. I strongly recommend doing a busy loop for the same amount of time. For instance checking every 5s whether it booted, and doing the rest of the actions after the timeout rings. On line 885 there is already the busy loop that you just described that checks the vm every 5 seconds for 5 minutes. The purpose of the 2 minute delay is to reduce the amount of checks in the log. I am open to suggestions. I could increase the wait time in the loop?\ Maybe rather than just a 2 minute solid delay, do a silent check every 5

seconds for 5 minutes (so exactly what we were doing, but just with no visible output) and then once the check is successful, then do whatever we want to test. It's a fair point in that sometimes a VM may spin up faster than 2 minutes, and sometimes slower than 2 minutes... so basically we assume it WILL spin up in 5 minutes or else it's failed, and exit the check loop as soon as we see it's ready (the ssh is successful) or the timeout is met, and then "do stuff" or mark it as failed to boot.

…

The codecov is unhappy about the shrinking coverage. Also in the PR template there should have been an info about the suffix that helps us generate the changelog automatically (in this case (BugFix)). I added (BugFix) in the Description is that correct? How do we resolve these codecov things? I will be happy to assist you if you need more hands on those issues. Any assistance is appreciated — Reply to this email directly, view it on GitHub <#720 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAYWSCUYLNDAQSF6GPLBO3X2NSSXANCNFSM6AAAAAA4WZAZIA> . You are receiving this because you commented.Message ID: ***@***.***>

-- Jeff Lane - Engineering Manager, Tools Developer, Warrior Poet, Lover of Pie Ubuntu Ham: W4KDH Freenode IRC: bladernr or bladernr_ gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD

[mreed8855]

I have created a different PR that replaces this. #743 I will close this PR.