Update the Virtualization Test to Clean up Logs (Bugfix)#743
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
==========================================
+ Coverage 37.06% 37.43% +0.37%
==========================================
Files 313 313
Lines 34805 34808 +3
Branches 5982 5983 +1
==========================================
+ Hits 12899 13029 +130
+ Misses 21335 21201 -134
- Partials 571 578 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hook25
previously requested changes
Sep 22, 2023
Collaborator
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
I have suggested a couple of ideas here and there, overall nice contribution, thank you.
To consider this ready I will need to ask you to write a few unit tests to improve the overall coverage of this contribution. Given that we have a 90% target on patches, covering cleanup and run_command should be enough but if you want/can, try to reach 100% (covering start_vm is going to be a little bit more complicated but we really need to improve the overall coverage of provider scripts and checkbox itself!).
Hook25
changed the title
mreed8855
force-pushed
the
vm_timeout_update_2
branch
from
79900bd to
0afd0db
Compare
Hook25
force-pushed
the
vm_timeout_update_2
branch
2 times, most recently
from
baad4a9 to
1922999
Compare
I have added an option to reduce the error messages shown in the logs while the script checks to see if the virtual machine has booted. (Bugfix) for issue #695 Updated suggested changes in PR review - Changed error_msgs to log_stderr - Replaced elif with a cleaner if statement
Hook25
force-pushed
the
vm_timeout_update_2
branch
from
be809d4 to
617fdb9
Compare
Add test for cleanup Fully test start_vm Partially test setup Add no stderr test
Hook25
force-pushed
the
vm_timeout_update_2
branch
from
617fdb9 to
ea4ada6
Compare
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
* Update the Virtualization Test Clean up Logs I have added an option to reduce the error messages shown in the logs while the script checks to see if the virtual machine has booted. (Bugfix) for issue canonical#695 Updated suggested changes in PR review - Changed error_msgs to log_stderr - Replaced elif with a cleaner if statement * Add a few tests to virtualization.py Add test for cleanup Fully test start_vm Partially test setup Add no stderr test * Updated tests and small refactoring of start_vm * Black run_command and setup * Recover deleted minor tests --------- Co-authored-by: Hook25 <massimiliano.girardi@canonical.com>
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
* Update the Virtualization Test Clean up Logs I have added an option to reduce the error messages shown in the logs while the script checks to see if the virtual machine has booted. (Bugfix) for issue canonical#695 Updated suggested changes in PR review - Changed error_msgs to log_stderr - Replaced elif with a cleaner if statement * Add a few tests to virtualization.py Add test for cleanup Fully test start_vm Partially test setup Add no stderr test * Updated tests and small refactoring of start_vm * Black run_command and setup * Recover deleted minor tests --------- Co-authored-by: Hook25 <massimiliano.girardi@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added an option to reduce the error messages shown in the logs while the script checks to see if the virtual machine has booted.
This fixes this issue
#695
Jira Card
https://warthogs.atlassian.net/browse/SERVCERT-1259
This PR will replace PR #720
Description
Resolved issues
#695
Documentation
Tests
Run checkbox and run the virtualization/verify_lxd_vm job