Skip to content

feat(cluster-link) add cluster link crud WD-23025#1332

Closed
edlerd wants to merge 1 commit intocanonical:mainfrom
edlerd:cluster-link-spike
Closed

feat(cluster-link) add cluster link crud WD-23025#1332
edlerd wants to merge 1 commit intocanonical:mainfrom
edlerd:cluster-link-spike

Conversation

@edlerd
Copy link
Copy Markdown
Collaborator

@edlerd edlerd commented Jun 25, 2025

Done

  • Interaction for cluster link crud

Fixes WD-23025

Draft state as this is still pending design and relies on canonical/lxd#14884

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • open the cluster link list
    • create a cluster link
    • delete a cluster link

Screenshots

Cluster links

image image image image image

@webteam-app
Copy link
Copy Markdown

@edlerd edlerd force-pushed the cluster-link-spike branch 4 times, most recently from 54f11db to 6272a3a Compare July 2, 2025 13:37
@edlerd edlerd force-pushed the cluster-link-spike branch 11 times, most recently from d76ed2f to c87ebbb Compare July 9, 2025 16:34
@edlerd edlerd force-pushed the cluster-link-spike branch 8 times, most recently from 06b82bc to 3c8993b Compare July 14, 2025 13:27
@edlerd edlerd force-pushed the cluster-link-spike branch 2 times, most recently from ac87eb6 to a794449 Compare July 15, 2025 13:03
@edlerd edlerd force-pushed the cluster-link-spike branch 8 times, most recently from 5d9da1c to e6e16e2 Compare July 21, 2025 15:17
@edlerd edlerd marked this pull request as ready for review July 21, 2025 15:19
@edlerd edlerd force-pushed the cluster-link-spike branch 9 times, most recently from a30ddf4 to d21377e Compare July 24, 2025 10:20
@edlerd edlerd force-pushed the cluster-link-spike branch 2 times, most recently from ea281d7 to 92ee885 Compare August 8, 2025 14:32
Copy link
Copy Markdown
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing took place within a microcloud instance.
Some notes:

  1. On my first time loading the cluster links list, I was met with this messaging. The notification is unfriendly (D:) and inconsistent with our usual pattern of just having an empty list page.
image 2. The empty list page also reloads periodically / when I go to another tab. Perhaps a reload usually happens in this case and this is normal, but the error notification is jarring. image
  1. A little nitpick, and may just be browser specific, but some left padding or margin may get rid of the cut-off radio highlighting:
image
  1. I created a clusterlink without specifying a group to see what would happen, and I received this message, perhaps we can have better error messaging?:
image
  1. Hmm... Cluster link creation did not seem to work for me. Do I need to configure my backend specially in any way? Again, bringing any error messaging to the surface may help diagnose.
image

@Kxiru
Copy link
Copy Markdown
Contributor

Kxiru commented Aug 20, 2025

I repeated the tests in my local / host (now clustered) backend and received the same results.
image

@edlerd edlerd marked this pull request as draft August 21, 2025 07:11
@edlerd
Copy link
Copy Markdown
Collaborator Author

edlerd commented Aug 21, 2025

Thanks for the review @Kxiru Sorry for the confusion here as the backend for this is not yet merged into LXD main branch.

Moving this back to draft as the backend PR got closed yesterday. So there is no backend to run this against, except for the closed PR state. I created this off a custom-built from that PR branch.

Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd
Copy link
Copy Markdown
Collaborator Author

edlerd commented Sep 16, 2025

Closing this for now as the backend is not yet merged and taken back into design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants