feat(cluster-link) add cluster link crud WD-23025#1332
Closed
edlerd wants to merge 1 commit intocanonical:mainfrom
Closed
feat(cluster-link) add cluster link crud WD-23025#1332edlerd wants to merge 1 commit intocanonical:mainfrom
edlerd wants to merge 1 commit intocanonical:mainfrom
Conversation
54f11db to
6272a3a
Compare
d76ed2f to
c87ebbb
Compare
06b82bc to
3c8993b
Compare
ac87eb6 to
a794449
Compare
5d9da1c to
e6e16e2
Compare
a30ddf4 to
d21377e
Compare
ea281d7 to
92ee885
Compare
Kxiru
reviewed
Aug 20, 2025
Contributor
Kxiru
left a comment
There was a problem hiding this comment.
Testing took place within a microcloud instance.
Some notes:
- On my first time loading the cluster links list, I was met with this messaging. The notification is unfriendly (D:) and inconsistent with our usual pattern of just having an empty list page.
2. The empty list page also reloads periodically / when I go to another tab. Perhaps a reload usually happens in this case and this is normal, but the error notification is jarring.
- A little nitpick, and may just be browser specific, but some left padding or margin may get rid of the cut-off radio highlighting:
- I created a clusterlink without specifying a group to see what would happen, and I received this message, perhaps we can have better error messaging?:
- Hmm... Cluster link creation did not seem to work for me. Do I need to configure my backend specially in any way? Again, bringing any error messaging to the surface may help diagnose.
Contributor
Collaborator
Author
|
Thanks for the review @Kxiru Sorry for the confusion here as the backend for this is not yet merged into LXD main branch. Moving this back to draft as the backend PR got closed yesterday. So there is no backend to run this against, except for the closed PR state. I created this off a custom-built from that PR branch. |
Signed-off-by: David Edler <david.edler@canonical.com>
92ee885 to
181ded7
Compare
Collaborator
Author
|
Closing this for now as the backend is not yet merged and taken back into design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Done
Fixes WD-23025
Draft state as this is still pending design and relies on canonical/lxd#14884
QA
Screenshots
Cluster links