Merged
Conversation
jmuzina
added
Review: QA needed
Review: Code needed
Priority: High
Demo
Jenkins 
demos.haus 
jmuzina
force-pushed
the
feature/charm-cicd
branch
from
d001608 to
7dbb689
Compare
jmuzina
force-pushed
the
feature/charm-cicd
branch
from
3267150 to
39e9ef5
Compare
jmuzina
force-pushed
the
feature/charm-cicd
branch
from
39e9ef5 to
c8f8de6
Compare
advl
reviewed
Jun 27, 2025
| build-snaps: | ||
| - node/22/stable | ||
| override-build: | | ||
| set -eux |
advl
reviewed
Jun 27, 2025
Comment on lines
+29
to
+30
| mkdir -p "$CRAFT_PART_INSTALL/flask/app" | ||
| cp -r build "$CRAFT_PART_INSTALL/flask/app/" |
Contributor
There was a problem hiding this comment.
add comprehensive comment explaining why we're not using prime
advl
approved these changes
Jun 27, 2025
jmuzina
added a commit
that referenced
this pull request
Jul 9, 2025
* Add charm config / local dev docs * rm extra line * charm readme refinements * pack & upload charm in CIK * Use webteam devops workflow * tweak comments. partially for correctness, partially to force a rebuild with the updated juju controller names * add comments * note about build * test one-job workflow * remove temporarily skipped check-charm-changes job * Revert "test one-job workflow" This reverts commit 3afb9d8. * use the devops workflow
jmuzina
added a commit
that referenced
this pull request
Jul 11, 2025
* Add charm config / local dev docs * rm extra line * charm readme refinements * pack & upload charm in CIK * Use webteam devops workflow * tweak comments. partially for correctness, partially to force a rebuild with the updated juju controller names * add comments * note about build * test one-job workflow * remove temporarily skipped check-charm-changes job * Revert "test one-job workflow" This reverts commit 3afb9d8. * use the devops workflow
jmuzina
added a commit
that referenced
this pull request
Jul 11, 2025
* Add charm config / local dev docs * rm extra line * charm readme refinements * pack & upload charm in CIK * Use webteam devops workflow * tweak comments. partially for correctness, partially to force a rebuild with the updated juju controller names * add comments * note about build * test one-job workflow * remove temporarily skipped check-charm-changes job * Revert "test one-job workflow" This reverts commit 3afb9d8. * use the devops workflow
jmuzina
added a commit
that referenced
this pull request
Jul 11, 2025
* Add charm config / local dev docs * rm extra line * charm readme refinements * pack & upload charm in CIK * Use webteam devops workflow * tweak comments. partially for correctness, partially to force a rebuild with the updated juju controller names * add comments * note about build * test one-job workflow * remove temporarily skipped check-charm-changes job * Revert "test one-job workflow" This reverts commit 3afb9d8. * use the devops workflow
jmuzina
added a commit
that referenced
this pull request
Jul 22, 2025
* Add charm config / local dev docs * rm extra line * charm readme refinements * pack & upload charm in CIK * Use webteam devops workflow * tweak comments. partially for correctness, partially to force a rebuild with the updated juju controller names * add comments * note about build * test one-job workflow * remove temporarily skipped check-charm-changes job * Revert "test one-job workflow" This reverts commit 3afb9d8. * use the devops workflow
jmuzina
added a commit
that referenced
this pull request
Aug 11, 2025
* start charm migration - it packs! * charm deploy workflow * debug ci tweak * change ghcr registry to correct VF identiifer * charmhub app.py * fix container failing to start * notes from johann * rock adjustments * tweak workflow * Update rock metadata * docs/workflow tweaks * local dev container should not be detached * remove some unnecessary `prime` files from the rock, added more explanatory comments to the prime files * Switch skopeo * just use ubuntu lib skopeo * Add charm config / local dev docs (#5557) * Add charm config / local dev docs * rm extra line * charm readme refinements * note about using the PAAS charm * ci: Add Charm CI/CD (#5558) * Add charm config / local dev docs * rm extra line * charm readme refinements * pack & upload charm in CIK * Use webteam devops workflow * tweak comments. partially for correctness, partially to force a rebuild with the updated juju controller names * add comments * note about build * test one-job workflow * remove temporarily skipped check-charm-changes job * Revert "test one-job workflow" This reverts commit 3afb9d8. * use the devops workflow * add env vars to the charm deployment (#5575)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Part 4 (hopefully final) of #5551
Based on #5557 , merge that first
Uses webteam-devops deploy action.
QA