fix(file-uploader-button): avoid state updates during render#21534
Open
adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
Open
fix(file-uploader-button): avoid state updates during render#21534adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21534 +/- ##
==========================================
+ Coverage 86.89% 86.94% +0.04%
==========================================
Files 540 540
Lines 43438 43450 +12
Branches 6648 6713 +65
==========================================
+ Hits 37745 37776 +31
+ Misses 5527 5507 -20
- Partials 166 167 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue.
Avoided state updates during render in
FileUploaderButton.Changelog
Changed
FileUploaderButton.Testing / Reviewing
FileUploaderButtonwas setting state during render which is an anti-pattern.Existing tests should cover these changes.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesWrote passing tests that cover this changeMore details can be found in the pull request guide