Skip to content

fix(file-uploader-button): avoid state updates during render #21534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamalston wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(file-uploader-button): avoid state updates during render #21534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions packages/react/src/components/FileUploader/FileUploaderButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
/**
* Copyright IBM Corp. 2016, 2025
* Copyright IBM Corp. 2016, 2026
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
*/

import cx from 'classnames';
import PropTypes from 'prop-types';
import React, { useRef, useState, type HTMLAttributes } from 'react';
import React, { useEffect, useRef, useState, type HTMLAttributes } from 'react';
import { matches, keys } from '../../internal/keyboard';
import { useId } from '../../internal/useId';
import { usePrefix } from '../../internal/usePrefix';
Expand Down Expand Up @@ -121,7 +121,6 @@ function FileUploaderButton({
}: FileUploaderButtonProps) {
const prefix = usePrefix();
const [labelText, setLabelText] = useState(ownerLabelText);
const [prevOwnerLabelText, setPrevOwnerLabelText] = useState(ownerLabelText);
const generatedId = useId();
const { current: inputId } = useRef(id || generatedId);
const inputNode = useRef<HTMLInputElement>(null);
Expand All @@ -134,11 +133,9 @@ function FileUploaderButton({
[`${prefix}--layout--size-${size}`]: size,
});

// Adjust label text state based on changes to the labelText prop
if (ownerLabelText !== prevOwnerLabelText) {
useEffect(() => {
setLabelText(ownerLabelText);
setPrevOwnerLabelText(ownerLabelText);
}
}, [ownerLabelText]);

function onClick(event) {
event.target.value = null;
Expand Down
Loading