Draft
Conversation
thesimplekid
force-pushed
the
onchain_bdk
branch
2 times, most recently
from
ca08cae to
bdc06cf
Compare
thesimplekid
force-pushed
the
onchain_bdk
branch
4 times, most recently
from
3a49397 to
caf4bec
Compare
thesimplekid
added
the
stacked hold
The wallet's update_melt_quote_state() was receiving the payment_proof parameter and forwarding it to add_transaction_for_pending_melt() but never writing it to the persisted quote record. As a result, the proof (lightning preimage / onchain outpoint) was never visible on the quote itself after a successful melt, only in the transaction log. Assign payment_proof to quote.payment_proof before persistence, and carry it through the ConcurrentUpdate retry path.
- Pass optional onchain config through create_fake_wallet_settings() - Add onchain: None field to Settings struct literals in regtest mint setup
thesimplekid
force-pushed
the
onchain_bdk
branch
from
caf4bec to
73b5d6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing